When trying to edit items via batch item modification, the subfield i does not display. To recreate, add a value to 952$i, then add that barcode to the batch item modification function. You will see the value display in the item summary across the top of the screen, but the $i does not show in the edit section below.
Created attachment 110710 [details] [review] Bug 24780: Make items.stocknumber show up in batch item modification It looks like the field was intentionally removed from the list of batch editable fields in the past. This makes sense as we used to have a unique index on it at some point - but we do have no more. This removes the exception so that the invendory number behaves like the other fields on the batch item edit form. To test: - Create some items with and without stocknumber - Go to tools > batch item modification - Enter the barcodes of your selected items in the list or upload a file with them - Verify that the stocknumber/inventory number is not showing in the item edit form below - Apply patch - Reload the page - inventory number is there now - Batch edit the inventory number and verify it works as expected
Created attachment 110711 [details] [review] Bug 24780: Make items.stocknumber show up in batch item modification It looks like the field was intentionally removed from the list of batch editable fields in the past. This makes sense as we used to have a unique index on it at some point - but we do have no more. This removes the exception so that the invendory number behaves like the other fields on the batch item edit form. To test: - Create some items with and without stocknumber - Go to tools > batch item modification - Enter the barcodes of your selected items in the list or upload a file with them - Verify that the stocknumber/inventory number is not showing in the item edit form below - Apply patch - Reload the page - inventory number is there now - Batch edit the inventory number and verify it works as expected Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Created attachment 110740 [details] [review] Bug 24780: Make items.stocknumber show up in batch item modification It looks like the field was intentionally removed from the list of batch editable fields in the past. This makes sense as we used to have a unique index on it at some point - but we do have no more. This removes the exception so that the invendory number behaves like the other fields on the batch item edit form. To test: - Create some items with and without stocknumber - Go to tools > batch item modification - Enter the barcodes of your selected items in the list or upload a file with them - Verify that the stocknumber/inventory number is not showing in the item edit form below - Apply patch - Reload the page - inventory number is there now - Batch edit the inventory number and verify it works as expected Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Trivial fix that makes sense, no regressions found. Passing QA
Pushed to master for 20.11, thanks to everybody involved!
backported to 20.05.x for 20.05.05
backported to 19.11.x for 19.11.11
Backported to 19.05.x branch for 19.05.17