During development there was support added for a secondary macro format, however, I do not believe it was fully supported or documented. It was based on another ILS macro format I believe As the rancor format was documented and explained I think we should remove the other format. According to original developer this was intended to be done before submission.
Created attachment 100005 [details] [review] Bug 24789: Remove ITS macro format To test: 1 - Apply patches 2 - Confirm you can save, load, and run macros 3 - Confirm you have no choice of format
Hmm, I think I thought the ITS format may be marginally more functional that our own so I wondered if rather than removal we should fully document it. Were there copyright issues that required it's removal perhaps.. if so I'd love to see any missing functionality added into our own macro format as part of a removal?
Martin, In our (DGI's) experience, the ITS functionality in Koha isn't completely compatible with a macro exported out of ITS. In all cases I was able to create a Koha macro functionally the same as the ITS macro (albeit in multiple lines where the ITS version may have had 1).
That's good to know Cori, sounds like we can indeed nuke it then. :)
Created attachment 100578 [details] [review] Bug 24789: Remove ITS macro format To test: 1 - Apply patches 2 - Confirm you can save, load, and run macros 3 - Confirm you have no choice of format Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Created attachment 100700 [details] [review] Bug 24789: Remove ITS macro format To test: 1 - Apply patches 2 - Confirm you can save, load, and run macros 3 - Confirm you have no choice of format Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Please update text to go into release notes for this one!
Nice work everyone! Pushed to master for 20.05
Created attachment 100757 [details] [review] Bug 24789: [follow-up] Fix saving of macros Saving was accidentally commented out in patches, this restores that To test: 1 - Create a new macro 2 - Add some content 3 - Reload the macro, no content 4 - Apply patch 5 - Repeat 6 - Macro saves/loads correctly
backported to 19.11.x branch for 19.11.05
backported to 19.05.x for 19.05.10
Enhancement/minor will not be backported to 18.11.x series