Bug 24829 - ClaimReturnedWarningThreshold is always triggered if patron has one or more claims
Summary: ClaimReturnedWarningThreshold is always triggered if patron has one or more c...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Kyle M Hall (khall)
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-09 13:33 UTC by Kyle M Hall (khall)
Modified: 2020-11-30 21:46 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
20.05.00, 19.11.05
Circulation function:

Attachments
Bug 24829: ClaimReturnedWarningThreshold is always triggered if patron has one or more claims (1.82 KB, patch)
2020-03-09 13:37 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Bug 24829: ClaimReturnedWarningThreshold is always triggered if patron has one or more claims (1.87 KB, patch)
2020-03-24 13:53 UTC, PTFS Europe Sandboxes 		Details | Diff | Splinter Review
Bug 24829: ClaimReturnedWarningThreshold is always triggered if patron has one or more claims (1.93 KB, patch)
2020-03-25 21:44 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall (khall) 2020-03-09 13:33:48 UTC 
ClaimReturnedWarningThreshold is supposed to display a warning if a patron has more than the number of claims specified in the system preference. Currently the warning is displayed for any number of claims over zero.
Comment 1 Kyle M Hall (khall) 2020-03-09 13:37:13 UTC 
Created attachment 100375 [details] [review]
Bug 24829: ClaimReturnedWarningThreshold is always triggered if patron has one or more claims

ClaimReturnedWarningThreshold is supposed to display a warning if a patron has more than the number of claims specified in the system preference. Currently the warning is displayed for any number of claims over zero.

Test Plan:
1) Make 3 return claims for a patron
2) Set ClaimReturnedWarningThreshold to 4
3) Note the claims warning displays for the patron on circulation.pl
4) Apply this patch
5) Reload circulation.pl, the warning should go away
6) Set ClaimReturnedWarningThreshold to 2
7) Reload the page, the warning should reappear
Comment 2 PTFS Europe Sandboxes 2020-03-24 13:53:26 UTC 
Created attachment 101582 [details] [review]
Bug 24829: ClaimReturnedWarningThreshold is always triggered if patron has one or more claims

ClaimReturnedWarningThreshold is supposed to display a warning if a patron has more than the number of claims specified in the system preference. Currently the warning is displayed for any number of claims over zero.

Test Plan:
1) Make 3 return claims for a patron
2) Set ClaimReturnedWarningThreshold to 4
3) Note the claims warning displays for the patron on circulation.pl
4) Apply this patch
5) Reload circulation.pl, the warning should go away
6) Set ClaimReturnedWarningThreshold to 2
7) Reload the page, the warning should reappear

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Comment 3 Katrin Fischer 2020-03-25 21:44:18 UTC 
Created attachment 101779 [details] [review]
Bug 24829: ClaimReturnedWarningThreshold is always triggered if patron has one or more claims

ClaimReturnedWarningThreshold is supposed to display a warning if a patron has more than the number of claims specified in the system preference. Currently the warning is displayed for any number of claims over zero.

Test Plan:
1) Make 3 return claims for a patron
2) Set ClaimReturnedWarningThreshold to 4
3) Note the claims warning displays for the patron on circulation.pl
4) Apply this patch
5) Reload circulation.pl, the warning should go away
6) Set ClaimReturnedWarningThreshold to 2
7) Reload the page, the warning should reappear

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Martin Renvoize (ashimema) 2020-03-26 11:40:35 UTC 
Nice work everyone!

Pushed to master for 20.05
Comment 5 Joy Nelson 2020-04-03 22:40:17 UTC 
backported to 19.11.x for 19.11.05