Created attachment 100394 [details] Some potential places to display report number It would be helpful to have a report display its number next to the report name after running. Currently, this information can be taken from the URL but displaying it directly would be great.
This is my first bug submission, so please let me know if I haven't followed correct protocol.
This could be very helpful to show on printed reports. Lisette
It would also be helpful to display a report's number when you are editing it.
Created attachment 110634 [details] [review] Bug 24834: Display report number on editing or running a report The only place the report ID was shown when editing or running a report was in the URL. With this patch, we also show it in the heading, the breadcrumbs and the page title. To test: - Create a new SQL report. - Save the report. - Edit the report. - Verify that the report id now shows in the breadcrumbs and page title. - Run your report. - Verify the report id shows in the page heading, title and breadcrumbs.
Created attachment 110669 [details] [review] Bug 24834: Display report number on editing or running a report The only place the report ID was shown when editing or running a report was in the URL. With this patch, we also show it in the heading, the breadcrumbs and the page title. To test: - Create a new SQL report. - Save the report. - Edit the report. - Verify that the report id now shows in the breadcrumbs and page title. - Run your report. - Verify the report id shows in the page heading, title and breadcrumbs. Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com>
Everything worked great, the title in the tab is very long, so I had to bookmark it to confirm the title was correct. Lisette
(In reply to Lisette Scheer from comment #6) > Everything worked great, the title in the tab is very long, so I had to > bookmark it to confirm the title was correct. > Lisette Ah, I think I was testing with a short one - hope it's still ok! - Thx Lisette!
Created attachment 110673 [details] [review] Bug 24834: Display report number on editing or running a report The only place the report ID was shown when editing or running a report was in the URL. With this patch, we also show it in the heading, the breadcrumbs and the page title. To test: - Create a new SQL report. - Save the report. - Edit the report. - Verify that the report id now shows in the breadcrumbs and page title. - Run your report. - Verify the report id shows in the page heading, title and breadcrumbs. Signed-off-by: Michael A <madamyk@ckls.org>
Created attachment 110674 [details] Not displaying report number in page title I was unable to see the report number in the page title, whether when hovering over the browser tab or adding a bookmark. Tested in Chrome, Firefox, and Safari. The other locations look great! Thank you for working on this!
Lisette tested this as well on the stream, and didn't see the number displayed in the page title.
(In reply to madamyk from comment #10) > Lisette tested this as well on the stream, and didn't see the number > displayed in the page title. I'll fix it, thx for testing!
Created attachment 110704 [details] [review] Bug 24834: (follow-up) Add report id to page titles See test plan of previous patch!
Created attachment 110706 [details] [review] Bug 24834: Display report number on editing or running a report The only place the report ID was shown when editing or running a report was in the URL. With this patch, we also show it in the heading, the breadcrumbs and the page title. To test: - Create a new SQL report. - Save the report. - Edit the report. - Verify that the report id now shows in the breadcrumbs and page title. - Run your report. - Verify the report id shows in the page heading, title and breadcrumbs. Signed-off-by: Michael A <madamyk@ckls.org> Signed-off-by: Michael Adamyk <madamyk@ckls.org>
Created attachment 110707 [details] [review] Bug 24834: (follow-up) Add report id to page titles See test plan of previous patch! Signed-off-by: Michael Adamyk <madamyk@ckls.org>
It's working for me, and displaying in all 3 locations now.
Created attachment 110708 [details] [review] Bug 24834: Display report number on editing or running a report The only place the report ID was shown when editing or running a report was in the URL. With this patch, we also show it in the heading, the breadcrumbs and the page title. To test: - Create a new SQL report. - Save the report. - Edit the report. - Verify that the report id now shows in the breadcrumbs and page title. - Run your report. - Verify the report id shows in the page heading, title and breadcrumbs. Signed-off-by: Michael A <madamyk@ckls.org> Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com>
Created attachment 110709 [details] [review] Bug 24834: (follow-up) Add report id to page titles See test plan of previous patch! Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com>
Hmm, there are some inconsistencies in the navigational changes here.. I wonder if it would be nicer/better to make them consistently follow Home › Reports › Guided reports wizard › Saved reports › $report_name › Action So.. * Home › Reports › Guided reports wizard › Saved reports › $report_name › View * Home › Reports › Guided reports wizard › Saved reports › $report_name › Edit * Home › Reports › Guided reports wizard › Saved reports › $report_name › Run Just a thought whilst I'm QAing. I'm also working through understanding the distinction between the 'name' and 'reportname' parameter that's passed to the template.
Also.. minor QA failure.. you forgot a filter on that followup Katrin ;)
In fact... for that nav change.. could we perhaps go with: SQL View * Home › Reports › Guided reports wizard › Saved reports › $report_name SQL Edit * Home › Reports › Guided reports wizard › Saved reports › $report_name › Edit ^ Linked back to SQL View Run * Home › Reports › Guided reports wizard › Saved reports › $report_name › Run ^ Linked back to SQL View
Created attachment 111602 [details] [review] Bug 24834: Display report number on editing or running a report The only place the report ID was shown when editing or running a report was in the URL. With this patch, we also show it in the heading, the breadcrumbs and the page title. To test: - Create a new SQL report. - Save the report. - Edit the report. - Verify that the report id now shows in the breadcrumbs and page title. - Run your report. - Verify the report id shows in the page heading, title and breadcrumbs. Signed-off-by: Michael A <madamyk@ckls.org> Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 111603 [details] [review] Bug 24834: (follow-up) Add report id to page titles See test plan of previous patch! Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 111604 [details] [review] Bug 24834: (QA follow-up) Add missing filter Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 111605 [details] [review] Bug 24834: (follow-up) Improve breadcrumb This patch updates the breadcrumb navigation to be consistent for View, Edit and Run with the report name (and id in brackets) appropraitely placed in the breadcrumb with a link back to the view and the 'Action' clearly listed as the final part of the breadcrumb path. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
I've added a couple of follow-ups: One to squash the QA error and another to implement my proposed addition. The breadcrumb and page titles are inconsistent with the final patch but I wanted some opinions on that.. should the title match the breadcrumb, or should we drop some of the path to highlight the information we're interested in?.. for me the title is soooo long that even with the tab hovered I can't see the actual report name or id in it.
> The breadcrumb and page titles are inconsistent with the final patch but I > wanted some opinions on that.. should the title match the breadcrumb, or > should we drop some of the path to highlight the information we're > interested in?.. for me the title is soooo long that even with the tab > hovered I can't see the actual report name or id in it. I think dropping some of the path so we can highlight the information we want would be great for end users.
Created attachment 111806 [details] [review] Bug 24834: Display report number on editing or running a report The only place the report ID was shown when editing or running a report was in the URL. With this patch, we also show it in the heading, the breadcrumbs and the page title. To test: - Create a new SQL report. - Save the report. - Edit the report. - Verify that the report id now shows in the breadcrumbs and page title. - Run your report. - Verify the report id shows in the page heading, title and breadcrumbs. Signed-off-by: Michael A <madamyk@ckls.org> Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 111807 [details] [review] Bug 24834: (follow-up) Add report id to page titles See test plan of previous patch! Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 111808 [details] [review] Bug 24834: (QA follow-up) Add missing filter Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 111809 [details] [review] Bug 24834: (follow-up) Improve breadcrumb This patch updates the breadcrumb navigation to be consistent for View, Edit and Run with the report name (and id in brackets) appropraitely placed in the breadcrumb with a link back to the view and the 'Action' clearly listed as the final part of the breadcrumb path. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
(In reply to Lisette Scheer from comment #26) > > The breadcrumb and page titles are inconsistent with the final patch but I > > wanted some opinions on that.. should the title match the breadcrumb, or > > should we drop some of the path to highlight the information we're > > interested in?.. for me the title is soooo long that even with the tab > > hovered I can't see the actual report name or id in it. > > I think dropping some of the path so we can highlight the information we > want would be great for end users. I'm going to open another bug for this as I think it deserves a wider conversation and consistent treatment throughout.
Bug 26703 for the title discussion
Pushed to master for 20.11, thanks to everybody involved!