Created attachment 100721 [details] [review] Bug 24876: Fix capitalization on patron search for holds When placing a hold in the staff interface, the heading on the search box reads: Search Patrons or clubs The patch changes it to be Search patrons... instead. Also changes club id to club ID. To test: - Place a hold in the staff interface - Verify the capitalization error - Switch tabs to Clubs, see: club id - Apply patch - Verify it's all good now
Created attachment 100722 [details] [review] Bug 24876: Fix capitalization on patron search for holds When placing a hold in the staff interface, the heading on the search box reads: Search Patrons or clubs The patch changes it to be Search patrons... instead. Also changes club id to club ID. To test: - Place a hold in the staff interface - Verify the capitalization error - Switch tabs to Clubs, see: club id - Apply patch - Verify it's all good now
Sorry
Created attachment 101352 [details] [review] Bug 24876: Fix capitalization on patron search for holds When placing a hold in the staff interface, the heading on the search box reads: Search Patrons or clubs The patch changes it to be Search patrons... instead. Also changes club id to club ID. To test: - Place a hold in the staff interface - Verify the capitalization error - Switch tabs to Clubs, see: club id - Apply patch - Verify it's all good now
(In reply to Bernardo Gonzalez Kriegel from comment #3) > Sorry No need to - new patch attached :)
Created attachment 101354 [details] [review] Bug 24876: Fix capitalization on patron search for holds When placing a hold in the staff interface, the heading on the search box reads: Search Patrons or clubs The patch changes it to be Search patrons... instead. Also changes club id to club ID. To test: - Place a hold in the staff interface - Verify the capitalization error - Switch tabs to Clubs, see: club id - Apply patch - Verify it's all good now Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Created attachment 101490 [details] [review] Bug 24876: Fix capitalization on patron search for holds When placing a hold in the staff interface, the heading on the search box reads: Search Patrons or clubs The patch changes it to be Search patrons... instead. Also changes club id to club ID. To test: - Place a hold in the staff interface - Verify the capitalization error - Switch tabs to Clubs, see: club id - Apply patch - Verify it's all good now Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Nice work everyone! Pushed to master for 20.05
backported to 19.11.x for 19.11.05