When OpacAllowPublicListCreation is disabled (i.e. patrons are not allowed to create public lists from the OPAC), there shouldn't be a 'New list' button in the 'Public lists' tab. I am aware this does not enable patrons to create public lists, but it can be confusing, since it is in the 'Public lists' tab. To replicate: 1) In Administration > Global system preferences, search for OpacAllowPublicListCreation 2) Choose "Don't allow" and Save 3) Go to the OPAC and log into an account 4) In your account go to "your lists" 5) Click on the "Public lists" tab Note there is a 'New list' button.
Agree. This is confusing to the patron. Rhonda K.
Created attachment 108414 [details] [review] Bug 24884: Remove 'New list' button in 'Public lists' tab if OpacAllowPublicListCreation is disabled This patch adds a check on the OpacAllowPublicListCreation system preference to the OPAC lists template so that if public list creation is disabled the "New list" button doesn't appear under the "Public lists" tab. To test, apply the patch and confirm that the virtualshelves preference is enabled. - With the OpacAllowPublicListCreation system preference enabled, go to the OPAC and view the lists page. - If you are logged in you should see a "New list" link under both the "Your lists" tab and the "Public lists" tab. - If you are not logged in you should see "Log in to create a new list" on both pages. - View the page with OpacAllowPublicListCreation disabled. - If you are logged in you should see a "New list" link under only the "Your lists" tab. - If you are not logged in you should see the "Log in" link only under the "Your lists" tab.
Created attachment 108416 [details] [review] Bug 24884: Remove 'New list' button in 'Public lists' tab if OpacAllowPublicListCreation is disabled This patch adds a check on the OpacAllowPublicListCreation system preference to the OPAC lists template so that if public list creation is disabled the "New list" button doesn't appear under the "Public lists" tab. To test, apply the patch and confirm that the virtualshelves preference is enabled. - With the OpacAllowPublicListCreation system preference enabled, go to the OPAC and view the lists page. - If you are logged in you should see a "New list" link under both the "Your lists" tab and the "Public lists" tab. - If you are not logged in you should see "Log in to create a new list" on both pages. - View the page with OpacAllowPublicListCreation disabled. - If you are logged in you should see a "New list" link under only the "Your lists" tab. - If you are not logged in you should see the "Log in" link only under the "Your lists" tab. Works perfectly! Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Created attachment 108425 [details] [review] Bug 24884: Remove 'New list' button in 'Public lists' tab if OpacAllowPublicListCreation is disabled This patch adds a check on the OpacAllowPublicListCreation system preference to the OPAC lists template so that if public list creation is disabled the "New list" button doesn't appear under the "Public lists" tab. To test, apply the patch and confirm that the virtualshelves preference is enabled. - With the OpacAllowPublicListCreation system preference enabled, go to the OPAC and view the lists page. - If you are logged in you should see a "New list" link under both the "Your lists" tab and the "Public lists" tab. - If you are not logged in you should see "Log in to create a new list" on both pages. - View the page with OpacAllowPublicListCreation disabled. - If you are logged in you should see a "New list" link under only the "Your lists" tab. - If you are not logged in you should see the "Log in" link only under the "Your lists" tab. Works perfectly! Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 20.11, thanks to everybody involved!
enhancement will not be backported to 20.05.x