The transferbook method in C4::Circulation is lacking allot of tests.. I'd like to remove this method entirely at some point, but before we do that I think we need thorough tests adding to prevent refressions.
Created attachment 100996 [details] [review] Bug 24901: Minor refactor of tests Test plan: 0/ Read the change and verify it makes sense
Created attachment 100997 [details] [review] Bug 24901: Add tests for transferbook Test plan: 0/ Read the commit and confirm the new tests make sence 1/ Run the tests and verify they pass 2/ Signoff
Created attachment 101007 [details] [review] Bug 24901: Minor refactor of tests Test plan: 0/ Read the change and verify it makes sense Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 101008 [details] [review] Bug 24901: Add tests for transferbook Test plan: 0/ Read the commit and confirm the new tests make sence 1/ Run the tests and verify they pass 2/ Signoff Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Tests only, passing QA
Maybe remove that before push: +#subtest 'UseBranchTransferLimits tests' => sub { +# plan tests => 0; +#}; +
Nice work everyone! Pushed to master for 20.05
backported to 19.11.x branch for 19.11.05
Created attachment 102519 [details] [review] Bug 24901: Fix tests for 19.11.x
19.11.x patch applied.