"Save" button on last step does not save (!) It should be renamed "Next" instead https://snipboard.io/gXntf8.jpg Next step has a "Save report" button that actually saves.
Created attachment 101773 [details] [review] Bug 24976: Guided report - "Save" button on last step is misleading This patch changes the text of the save button on the final step. To test: 1) Build a guided report (the selections are immaterial) 2) Note that after you have been through the six stages, the button on the "Confirm custom report" screen should be labelled "Save" 3) Install patch 4) Repeat Step 1. Note that on the "Confirm custom report" screen, the button is now labelled "Next". 5) Run the report to check that the functionality still works.
Created attachment 101801 [details] [review] Bug 24976: Guided report - "Save" button on last step is misleading This patch changes the text of the save button on the final step. To test: 1) Build a guided report (the selections are immaterial) 2) Note that after you have been through the six stages, the button on the "Confirm custom report" screen should be labelled "Save" 3) Install patch 4) Repeat Step 1. Note that on the "Confirm custom report" screen, the button is now labelled "Next". 5) Run the report to check that the functionality still works. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Created attachment 101809 [details] [review] Bug 24976: Guided report - "Save" button on last step is misleading This patch changes the text of the save button on the final step. To test: 1) Build a guided report (the selections are immaterial) 2) Note that after you have been through the six stages, the button on the "Confirm custom report" screen should be labelled "Save" 3) Install patch 4) Repeat Step 1. Note that on the "Confirm custom report" screen, the button is now labelled "Next". 5) Run the report to check that the functionality still works. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 101810 [details] [review] Bug 24976: Guided report - "Save" button on last step is misleading This patch changes the text of the save button on the final step. To test: 1) Build a guided report (the selections are immaterial) 2) Note that after you have been through the six stages, the button on the "Confirm custom report" screen should be labelled "Save" 3) Install patch 4) Repeat Step 1. Note that on the "Confirm custom report" screen, the button is now labelled "Next". 5) Run the report to check that the functionality still works. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Devinim <kohadevinim@devinim.com.tr>
Nice work everyone! Pushed to master for 20.05
not backported to 19.11.x. does not apply please rebase if needed.