The Log Viewer uses select dropdowns. You are able to select more than one option at a time but it isn't clear that you can do this. Also the size of the dropdown means options are squashed and you have to scroll to see all of your options/selections.
Created attachment 101781 [details] [review] Bug 24982: Use checkboxes in Log Viewer So we can see all options at once, and more easily select more than one option. Test plan: 1) Go to Tools -> Log viewer 2) Notice the new checkboxes under Modules, Actions and Interface. 'All' should be selected by default for all three options 3) Confirm you can deselect 'All' and the other options are enabled. Confirm selection all of the other options automatically selects 'All' and disables the options again. 4) Confirm the results still work as expected when clicking 'Submit' button Sponsored-by: Catalyst IT
Created attachment 101782 [details] [review] Bug 24982: Use checkboxes in Log Viewer So we can see all options at once, and more easily select more than one option. Test plan: 1) Go to Tools -> Log viewer 2) Notice the new checkboxes under Modules, Actions and Interface. 'All' should be selected by default for all three options 3) Confirm you can deselect 'All' and the other options are enabled. Confirm selection all of the other options automatically selects 'All' and disables the options again. 4) Confirm the results still work as expected when clicking 'Submit' button Sponsored-by: Catalyst IT
Created attachment 101799 [details] [review] Bug 24982: Use checkboxes in Log Viewer So we can see all options at once, and more easily select more than one option. Test plan: 1) Go to Tools -> Log viewer 2) Notice the new checkboxes under Modules, Actions and Interface. 'All' should be selected by default for all three options 3) Confirm you can deselect 'All' and the other options are enabled. Confirm selection all of the other options automatically selects 'All' and disables the options again. 4) Confirm the results still work as expected when clicking 'Submit' button Sponsored-by: Catalyst IT Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Created attachment 101824 [details] [review] Bug 24982: (follow-up) Give checkboxes more structured layout This patch makes minor markup changes and adds some CSS so that the module and actions checkboxes are laid out a little more clearly. The patch includes some whitespace changes, so diff accordingly.
Created attachment 101845 [details] [review] Bug 24982: (follow-up) Move checkboxes to left side of label
Created attachment 101860 [details] [review] Bug 24982: Use checkboxes in Log Viewer So we can see all options at once, and more easily select more than one option. Test plan: 1) Go to Tools -> Log viewer 2) Notice the new checkboxes under Modules, Actions and Interface. 'All' should be selected by default for all three options 3) Confirm you can deselect 'All' and the other options are enabled. Confirm selection all of the other options automatically selects 'All' and disables the options again. 4) Confirm the results still work as expected when clicking 'Submit' button Sponsored-by: Catalyst IT Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Created attachment 101861 [details] [review] Bug 24982: (follow-up) Give checkboxes more structured layout This patch makes minor markup changes and adds some CSS so that the module and actions checkboxes are laid out a little more clearly. The patch includes some whitespace changes, so diff accordingly. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Created attachment 101862 [details] [review] Bug 24982: (follow-up) Move checkboxes to left side of label Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Created attachment 101869 [details] [review] Bug 24982: Use checkboxes in Log Viewer So we can see all options at once, and more easily select more than one option. Test plan: 1) Go to Tools -> Log viewer 2) Notice the new checkboxes under Modules, Actions and Interface. 'All' should be selected by default for all three options 3) Confirm you can deselect 'All' and the other options are enabled. Confirm selection all of the other options automatically selects 'All' and disables the options again. 4) Confirm the results still work as expected when clicking 'Submit' button Sponsored-by: Catalyst IT Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 101870 [details] [review] Bug 24982: (follow-up) Give checkboxes more structured layout This patch makes minor markup changes and adds some CSS so that the module and actions checkboxes are laid out a little more clearly. The patch includes some whitespace changes, so diff accordingly. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 101871 [details] [review] Bug 24982: (follow-up) Move checkboxes to left side of label Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 101872 [details] [review] Bug 24982: (follow-up) Retain checkbox selections after for submit Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Nice work everyone! Pushed to master for 20.05
enhancement not backported to 19.11.x