With JavaScript enabled the "Go" button associated with the OPAC search results re-sort form should be hidden. Looks like I accidentally removed a line of CSS with Bug 23915 which needs to get put back.
Created attachment 101995 [details] [review] Bug 24996: Unwanted CSS change unhides OPAC results sorting button This patch adds back a CSS selector which was incorrectly removed by Bug 23915. The "Go" button associated with the OPAC search results resort operation should be hidden if JavaScript is enabled. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) - Perform a search in the OPAC - On the search results page, there should be no "Go" button next to the re-sort/results per page selection fields.
Created attachment 102046 [details] [review] Bug 24996: Unwanted CSS change unhides OPAC results sorting button This patch adds back a CSS selector which was incorrectly removed by Bug 23915. The "Go" button associated with the OPAC search results resort operation should be hidden if JavaScript is enabled. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) - Perform a search in the OPAC - On the search results page, there should be no "Go" button next to the re-sort/results per page selection fields. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 102117 [details] [review] Bug 24996: Unwanted CSS change unhides OPAC results sorting button This patch adds back a CSS selector which was incorrectly removed by Bug 23915. The "Go" button associated with the OPAC search results resort operation should be hidden if JavaScript is enabled. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) - Perform a search in the OPAC - On the search results page, there should be no "Go" button next to the re-sort/results per page selection fields. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Nice work everyone! Pushed to master for 20.05
missing dependencies - not backported to 19.11.x