Hello All! I hope everyone staying safe during this time! Yesterday I was trying to give a staff member permission to view and approve the "Suggestions Pending Approval". I had given that user full rights to the 'Suggestion Management' permission, however the option did not appear until I also provided the user with 'Moderate patron comments' under tools. However, to continue testing this I removed the 'Suggestion Management' option and it did remove it. I think there is something wrong with the check of the suggestion management piece that is preventing it from showing unless moderate comments option is also selected. Thanks for looking into this. Christofer
One occurrence missing on commit ae53caa6818939274352fde85454c24112e6f984 Bug 22868: Move suggestions_manage subperm out of acquisition perm
Created attachment 102510 [details] [review] Bug 25005: (bug 22868 follow-up) Fix suggestions pending on main page There is a "Suggestions pending approval" link on the main page that is displayed if there are new suggestions and the logged in user has the permission to manage them. On bug bug 22868 the permission changed from acquisition.suggestions_manage to suggestions.suggestions_manage But in the template, one occurrence has not been replaced correctly (certainly because it was already wrong actually). Test plan: Create a suggestion at the OPAC Create a patron with the suggestions permission Use this patron to login at the staff interface => Without this patch the link does not appear on the main page => With this patch applied the link appears
Created attachment 102526 [details] [review] Bug 25005: (bug 22868 follow-up) Fix suggestions pending on main page There is a "Suggestions pending approval" link on the main page that is displayed if there are new suggestions and the logged in user has the permission to manage them. On bug bug 22868 the permission changed from acquisition.suggestions_manage to suggestions.suggestions_manage But in the template, one occurrence has not been replaced correctly (certainly because it was already wrong actually). Test plan: Create a suggestion at the OPAC Create a patron with the suggestions permission Use this patron to login at the staff interface => Without this patch the link does not appear on the main page => With this patch applied the link appears Signed-off-by: David Roberts <david@koha-ptfs.co.uk>
Created attachment 102694 [details] [review] Bug 25005: (bug 22868 follow-up) Fix suggestions pending on main page There is a "Suggestions pending approval" link on the main page that is displayed if there are new suggestions and the logged in user has the permission to manage them. On bug bug 22868 the permission changed from acquisition.suggestions_manage to suggestions.suggestions_manage But in the template, one occurrence has not been replaced correctly (certainly because it was already wrong actually). Test plan: Create a suggestion at the OPAC Create a patron with the suggestions permission Use this patron to login at the staff interface => Without this patch the link does not appear on the main page => With this patch applied the link appears Signed-off-by: David Roberts <david@koha-ptfs.co.uk> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Nice work everyone! Pushed to master for 20.05
does not apply to 19.11.x cleanly. please rebase if needed.
Created attachment 104350 [details] [review] [19.11.x version] Bug 25005: (bug 22868 follow-up) Fix suggestions pending on main page There is a "Suggestions pending approval" link on the main page that is displayed if there are new suggestions and the logged in user has the permission to manage them. On bug bug 22868 the permission changed from acquisition.suggestions_manage to suggestions.suggestions_manage But in the template, one occurrence has not been replaced correctly (certainly because it was already wrong actually). Test plan: Create a suggestion at the OPAC Create a patron with the suggestions permission Use this patron to login at the staff interface => Without this patch the link does not appear on the main page => With this patch applied the link appears Signed-off-by: David Roberts <david@koha-ptfs.co.uk> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Can this be ported to 19.11?
backported to 19.11.x for 19.11.10
Not backported to oldoldstable (19.05.x). Feel free to ask if it's needed.