See attached image. I open an authority record with two 024 fields (that do not have a $a subfield btw). The second field is not displayed correctly. Looks like the unordered list is not closed or so? On current master (writing this 31-03).
Created attachment 102125 [details] Screenshot authority editor
Owen, any idea ?
Also comes up with 014 and using $a. So no specific issue with 024 or not using $a.
Created attachment 102143 [details] [review] Bug 25022: Display problem in authority editor with repeatable field This patch corrects an error in the structure of the authority editor template so that repeating subfields do not generate invalid markup. The correction was found by comparing with addbiblio.tt. If you are viewing the diff, please note that some minor whitespace changes have been made. To reproduce, clone and and populate any repeatable subfield, save, and open the authority for editing again. The clones subfield will be formatting incorrectly, showing bullet points on each line. To test, apply the patch and reload the authority editor showing the record with the cloned subfield. It should display correctly.
Created attachment 102215 [details] [review] Bug 25022: Display problem in authority editor with repeatable field This patch corrects an error in the structure of the authority editor template so that repeating subfields do not generate invalid markup. The correction was found by comparing with addbiblio.tt. If you are viewing the diff, please note that some minor whitespace changes have been made. To reproduce, clone and and populate any repeatable subfield, save, and open the authority for editing again. The clones subfield will be formatting incorrectly, showing bullet points on each line. To test, apply the patch and reload the authority editor showing the record with the cloned subfield. It should display correctly. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Thanks Owen! Taking this to PQA right away. Small template correction.
Nice work everyone! Pushed to master for 20.05
backported to 19.11.x branch for 19.11.06
backported to 19.05.x for 19.05.11