To recreate: 1 - Add several suggestions to Koha 2 - Set them in different status, leaving at least one pending 3 - Go to home page, note it shows count of pending 4 - Click the link on home page 5 - It does not take you to correct tab #ASKED anchor for tab was removed by: commit 4494e8ba6ca7d28972fcc1161c680ecf0b091f62 BUg 23594
Created attachment 102337 [details] [review] Bug 25041: Restore #ASKED anchor in suggestions table On commit 4494e8ba6ca7d28972fcc1161c680ecf0b091f62 Bug 23594: Batch modification for itemtypes on suggestions page The anchors of the tabs on suggestion.pl has been replaced with tab_$count instead of the status code. There was a need at the time, but I cannot remember it. I restored the previous behavior, and did not find any regressions. Test plan: 1 - Add several suggestions to Koha 2 - Set them in different status, leaving at least one pending 3 - Go to home page, note it shows count of pending 4 - Click the link on home page 5 - It takes you to correct tab
Created attachment 102402 [details] [review] Bug 25041: Restore #ASKED anchor in suggestions table On commit 4494e8ba6ca7d28972fcc1161c680ecf0b091f62 Bug 23594: Batch modification for itemtypes on suggestions page The anchors of the tabs on suggestion.pl has been replaced with tab_$count instead of the status code. There was a need at the time, but I cannot remember it. I restored the previous behavior, and did not find any regressions. Test plan: 1 - Add several suggestions to Koha 2 - Set them in different status, leaving at least one pending 3 - Go to home page, note it shows count of pending 4 - Click the link on home page 5 - It takes you to correct tab Signed-off-by: David Nind <david@davidnind.com>
Created attachment 102462 [details] [review] Bug 25041: Restore #ASKED anchor in suggestions table On commit 4494e8ba6ca7d28972fcc1161c680ecf0b091f62 Bug 23594: Batch modification for itemtypes on suggestions page The anchors of the tabs on suggestion.pl has been replaced with tab_$count instead of the status code. There was a need at the time, but I cannot remember it. I restored the previous behavior, and did not find any regressions. Test plan: 1 - Add several suggestions to Koha 2 - Set them in different status, leaving at least one pending 3 - Go to home page, note it shows count of pending 4 - Click the link on home page 5 - It takes you to correct tab Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Nice work everyone! Pushed to master for 20.05
not needed in 19.11 and prior - not backported