For sites with very large amounts of due dates to extend ( tens of thousands ), it can take a very long time of the results to load ( if at all ). It would be good to have a way to bypass the confirmation screen, instead directly updating the due dates before displaying the results.
Created attachment 102650 [details] [review] Bug 25101: Add ability to skip previewing results when batch extending due dates For sites with very large amounts of due dates to extend ( tens of thousands ), it can take a very long time of the results to load ( if at all ). It would be good to have a way to bypass the confirmation screen, instead directly updating the due dates before displaying the results. Test Plan: 1) Apply this patch 2) Browse to tools/batch_extend_due_dates.pl 3) Note the new "Preview results" checkbox 4) Submit form with the checkbox unchecked, due dates should be updated without previewing the checkouts 5) Submit form with the checkbox checked, tool should function as it did previously
Created attachment 102654 [details] [review] Bug 25101: Add ability to skip previewing results when batch extending due dates For sites with very large amounts of due dates to extend ( tens of thousands ), it can take a very long time of the results to load ( if at all ). It would be good to have a way to bypass the confirmation screen, instead directly updating the due dates before displaying the results. Test Plan: 1) Apply this patch 2) Browse to tools/batch_extend_due_dates.pl 3) Note the new "Preview results" checkbox 4) Submit form with the checkbox unchecked, due dates should be updated without previewing the checkouts 5) Submit form with the checkbox checked, tool should function as it did previously Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com>
*** Bug 25088 has been marked as a duplicate of this bug. ***
Hi Kyle, Regarding the comments and numbers from bug 25088, I do not understand how this patch could fix the problem. Did you identify the bottleneck? I mean, if the preview screen timeout I am expecting the confirmation screen to timeout as well. And I feel like it's better to timeout in the preview screen if there are too many matching rows (at least there is not only an unknown part of the set that is modified). If it's really the first screen that is a problem, that means there are superfluoux datetime manipulations (see my patch on bug 25008 to give you an idea) or something else that is causing the timeout.
Also I think we should have the checkbox checked by default, and a note/tooltip explaining a bit what's doing exactly.
(In reply to Jonathan Druart from comment #5) > Also I think we should have the checkbox checked by default, and a > note/tooltip explaining a bit what's doing exactly. With this patch, it can at least run. I'll file a followup for that.
What about adding a command line script instead?
(In reply to Jonathan Druart from comment #7) > What about adding a command line script instead? The purpose of the tool is to allow librarians to update the due dates themselves. A cli tool would obviate the point of the tool.
Created attachment 106937 [details] [review] Bug 25101: (follow-up) Tick preview checkbox on by default This would prevent any unintended batch renewals as it is easy to miss the option in the screen.
Kyle, I added patch for enabling the checkbox by default. Please let us know how you want to proceed with this, now this in bit of a limbo state.
(In reply to Joonas Kylmälä from comment #10) > Kyle, I added patch for enabling the checkbox by default. Please let us know > how you want to proceed with this, now this in bit of a limbo state. That is fine by me!
(In reply to Kyle M Hall from comment #11) > That is fine by me! Just to be clear, ready for someone to QA?
Created attachment 109292 [details] [review] Bug 25101: Add ability to skip previewing results when batch extending due dates For sites with very large amounts of due dates to extend ( tens of thousands ), it can take a very long time of the results to load ( if at all ). It would be good to have a way to bypass the confirmation screen, instead directly updating the due dates before displaying the results. Test Plan: 1) Apply this patch 2) Browse to tools/batch_extend_due_dates.pl 3) Note the new "Preview results" checkbox 4) Submit form with the checkbox unchecked, due dates should be updated without previewing the checkouts 5) Submit form with the checkbox checked, tool should function as it did previously Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 109293 [details] [review] Bug 25101: (follow-up) Tick preview checkbox on by default This would prevent any unintended batch renewals as it is easy to miss the option in the screen. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 109294 [details] [review] Bug 25101: (QA follow-up) Add hint to new option Adds a hint about the large numbers behind the new checkbox option. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
If I understand correctly jumping the preview helps in that the renewals will be done. Even if the screen times out, they will finish in the background, but with the preview step in between, you never get there. I have tried to add the hint Joubu asked for - please feel free to rephrase!
No, the hint is not correct IMO. The preview will fail if there is a large amounts of due dates to extend.
Oh, you are right - good intentions, but wrong "direction". Kyle, could you provide a rephrase maybe?
* The preview will fail if there is a large amounts of due dates to extend. * This is recommended when changing very large numbers of due dates. I don't see the difference here. Jonathan, would you like me to use your direct phrasing as the hint?
I am not a native English speaker but for me the 2 sentences have opposite sense. The hint from Katrin's patch is "This is recommended when changing very large numbers of due dates." Which means: you should check it if you are processing a lot of issues. It's the reverse, if the checkbox is checked we are going to display the preview screen, which will fail if the amount of due dates is too large.
A new day, maybe the fix is simple: "This is not recommended when changing very large numbers of due dates."
(In reply to Jonathan Druart from comment #20) > I am not a native English speaker but for me the 2 sentences have opposite > sense. > > The hint from Katrin's patch is > "This is recommended when changing very large numbers of due dates." > > Which means: you should check it if you are processing a lot of issues. > > It's the reverse, if the checkbox is checked we are going to display the > preview screen, which will fail if the amount of due dates is too large. Ah! That wasn't clicking for me, thanks!
(In reply to Katrin Fischer from comment #21) > A new day, maybe the fix is simple: > > "This is not recommended when changing very large numbers of due dates." Perfect!
Created attachment 109425 [details] [review] Bug 25101: (QA follow-up) Fix hint for new option
Created attachment 109529 [details] [review] Bug 25101: Add ability to skip previewing results when batch extending due dates For sites with very large amounts of due dates to extend ( tens of thousands ), it can take a very long time of the results to load ( if at all ). It would be good to have a way to bypass the confirmation screen, instead directly updating the due dates before displaying the results. Test Plan: 1) Apply this patch 2) Browse to tools/batch_extend_due_dates.pl 3) Note the new "Preview results" checkbox 4) Submit form with the checkbox unchecked, due dates should be updated without previewing the checkouts 5) Submit form with the checkbox checked, tool should function as it did previously Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Bug 25101: (QA follow-up) Add hint to new option Adds a hint about the large numbers behind the new checkbox option. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Bug 25101: (QA follow-up) Fix hint for new option
Created attachment 109530 [details] [review] Bug 25101: (follow-up) Tick preview checkbox on by default This would prevent any unintended batch renewals as it is easy to miss the option in the screen. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 20.11, thanks to everybody involved!
enhancement will not be backported to 20.05.x