At some point some calls to maybe_add got an extra $server var in their parameter lists. This doubled parameter does nothing and should be removed.
Created attachment 102699 [details] [review] Bug 25107: Remove double passing of $server variable to maybe_add in C4::SIP::Sip::MsgType At some point some calls to maybe_add got an extra $server var in their parameter lists. This doubled parameter does nothing and should be removed. Test Plan: No change in behavior should be noted
Created attachment 103832 [details] [review] Bug 25107: Remove double passing of $server variable to maybe_add in C4::SIP::Sip::MsgType At some point some calls to maybe_add got an extra $server var in their parameter lists. This doubled parameter does nothing and should be removed. Test Plan: No change in behavior should be noted Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
sub maybe_add { my ($fid, $value, $server) = @_; This all looks correct to me, there are also lots of other calls without the 4th parameter to maybe_add.
Created attachment 104187 [details] [review] Bug 25107: Remove double passing of $server variable to maybe_add in C4::SIP::Sip::MsgType At some point some calls to maybe_add got an extra $server var in their parameter lists. This doubled parameter does nothing and should be removed. Test Plan: No change in behavior should be noted Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Nice work everyone! Pushed to master for 20.05
Backported to 19.11.x for 19.11.06
backported to 19.05.x for 19.05.11