When viewing a suggestion, the reason given by the library for accepting/rejecting the suggestion is not displayed. It shows, when the suggestion is edited: /cgi-bin/koha/suggestion/suggestion.pl?suggestionid=29&op=edit (shows) //cgi-bin/koha/suggestion/suggestion.pl?suggestionid=34&op=show (doesn't show)
Created attachment 104320 [details] [review] Bug 25130: Reason for accepting/rejecting a suggestion is not visible when viewing (not editing) The patch adds the suggestion management reason to the display when viewing a suggestion. To test: 1) Edit a suggestion and assign a reason for accepting it. 2) View the suggestion (/cgi-bin/koha/suggestion/suggestion.pl?suggestionid=XX&op=show, replacing XX with your suggestion ID) 3) Under suggestion management, the reason you've just assigned does not display. 4) Apply the patch 5) Check the display again - the Reason should now be visible directly under the status.
Created attachment 104321 [details] [review] Bug 25130: Reason for accepting/rejecting a suggestion is not visible when viewing (not editing) The patch adds the suggestion management reason to the display when viewing a suggestion. To test: 1) Edit a suggestion and assign a reason for accepting it. 2) View the suggestion (/cgi-bin/koha/suggestion/suggestion.pl?suggestionid=XX&op=show, replacing XX with your suggestion ID) 3) Under suggestion management, the reason you've just assigned does not display. 4) Apply the patch 5) Check the display again - the Reason should now be visible directly under the status. Signed-off-by: Abbey Holt <aholt@dubuque.lib.ia.us>
Created attachment 104633 [details] [review] Bug 25130: Reason for accepting/rejecting a suggestion is not visible when viewing (not editing) The patch adds the suggestion management reason to the display when viewing a suggestion. To test: 1) Edit a suggestion and assign a reason for accepting it. 2) View the suggestion (/cgi-bin/koha/suggestion/suggestion.pl?suggestionid=XX&op=show, replacing XX with your suggestion ID) 3) Under suggestion management, the reason you've just assigned does not display. 4) Apply the patch 5) Check the display again - the Reason should now be visible directly under the status. Signed-off-by: Abbey Holt <aholt@dubuque.lib.ia.us> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Thx David and Abbey!
Nice work everyone! Pushed to master for 20.05
Backported to 19.11.x for 19.11.06
Doesn't apply clean to 19.05.x, please rebase if needed