The syspref PatronSelfRegistrationLibraryList describes itself as being about self-registration, but also limits the libraries available for patron self-modification. This presents a problem for libraries that want to corral their self-reg patrons into one library but allow full patrons to move between libraries. I've only confirmed this on 19.05. Master is currently doing something else weird on this syspref, which I'll file a bug for separately. This is part of a larger muddling of selfreg and selfmod that it'd be helpful to get untangled. See also bug 13188 for separating out the mandatory fields for the two pages.
Bug around this syspref in master: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25137
Created attachment 103042 [details] [review] Bug 25136: Make PatronSelfRegistrationLibraryList only effect new registration This patch makes it so PatronSelfRegistrationLibraryList will only effect the registration from and not the modification form. TO TEST: 1. Turn on self reg and add some libaries to PatronSelfRegistrationLibraryList. 2. Notice that the libaries that display in the borrower_branchcode dropdown are the ones you selected on both the new registration from and the modification form. 3. Apply patch. 4. Now only the new registration from should show libaries on PatronSelfRegistrationLibraryList. 5. The modifciation dropdown should still show all libraries.
Created attachment 103056 [details] [review] Bug 25136: Make PatronSelfRegistrationLibraryList only effect new registration This patch makes it so PatronSelfRegistrationLibraryList will only effect the registration from and not the modification form. TO TEST: 1. Turn on self reg and add some libaries to PatronSelfRegistrationLibraryList. 2. Notice that the libaries that display in the borrower_branchcode dropdown are the ones you selected on both the new registration from and the modification form. 3. Apply patch. 4. Now only the new registration from should show libaries on PatronSelfRegistrationLibraryList. 5. The modifciation dropdown should still show all libraries. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Created attachment 103066 [details] [review] Bug 25136: Make PatronSelfRegistrationLibraryList only effect new registration This patch makes it so PatronSelfRegistrationLibraryList will only effect the registration from and not the modification form. TO TEST: 1. Turn on self reg and add some libaries to PatronSelfRegistrationLibraryList. 2. Notice that the libaries that display in the borrower_branchcode dropdown are the ones you selected on both the new registration from and the modification form. 3. Apply patch. 4. Now only the new registration from should show libaries on PatronSelfRegistrationLibraryList. 5. The modifciation dropdown should still show all libraries. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 103067 [details] [review] Bug 25136: join the 2 ifs Highlight that we only need this for action="new" Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Nice work everyone! Pushed to master for 20.05
missing dependencies - not backported to 19.11.x