There are some branches scattered around that should be libraries.
Created attachment 102890 [details] [review] Bug 25138: Terminology: Point of sale should use library instead of branch This fixes the navigation on the Point of sale page: Branch details => Library details And the heading and the 'no register defined for this branch/library' message on the page it links to. To test: - Activate cash registers and point of sales features - Go to the point of sales page - Verify text on the menu to the left - Click on the Branch/library details - verify text and heading
If you don't have a cash register set up (or you have archived the cash register for the library) and click on either: - 'Point of sale' from the main staff interface page (/cgi-bin/koha/pos/pay.pl) or - the 'Register details' page (/cgi-bin/koha/pos/register.pl) the message text has branch instead of libary: "You must have at least one cash register associated with this branch before you can record payments." Apart from that, everything else works as expected.
Created attachment 103070 [details] [review] Bug 25138: (follow-up) Terminology: Point of sale should use library instead of branch It has also been applied to the Register details page.
Created attachment 103076 [details] [review] Bug 25138: (follow-up) Terminology: Point of sale should use library instead of branch Signed-off-by: Devinim <kohadevinim@devinim.com.tr>
Created attachment 103077 [details] [review] Bug 25138: Terminology: Point of sale should use library instead of branch This fixes the navigation on the Point of sale page: Branch details => Library details And the heading and the 'no register defined for this branch/library' message on the page it links to. To test: - Activate cash registers and point of sales features - Go to the point of sales page - Verify text on the menu to the left - Click on the Branch/library details - verify text and heading Signed-off-by: Devinim <kohadevinim@devinim.com.tr>
Nice catch - thx!
Ignore half of comment 2 - was posted just before the follow-up patch was made and signed off! However, text change still required for /cgi-bin/koha/pos/pay.pl
Created attachment 103138 [details] [review] Bug 25138: Terminology: Point of sale should use library instead of branch This fixes the navigation on the Point of sale page: Branch details => Library details And the heading and the 'no register defined for this branch/library' message on the page it links to. To test: - Activate cash registers and point of sales features - Go to the point of sales page - Verify text on the menu to the left - Click on the Branch/library details - verify text and heading Signed-off-by: Devinim <kohadevinim@devinim.com.tr>
Created attachment 103139 [details] [review] Bug 25138: (follow-up) Terminology: Point of sale should use library instead of branch Signed-off-by: Devinim <kohadevinim@devinim.com.tr> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Nice work everyone! Pushed to master for 20.05
Created attachment 103194 [details] [review] Bug 25138: (follow-up) Point of sale should use library instead of branch Fixes a misssed occurence on the pay.tt page. To test: - Don't have a cash register set up (or you have archived the cash register for the library) - Go to 'Point of sale' from the main staff interface page - Verify library/branch in the note shown: You must have at least one cash register associated with this library before you can record payments. https://bugs.koha-community.org/show_bug.cgi?id=24138
Sneaking in a follow-up here for the one word change on pay.tt
(In reply to Katrin Fischer from comment #12) > Sneaking in a follow-up here for the one word change on pay.tt Thanks Katrin!
not backported to 19.11.x
(In reply to Katrin Fischer from comment #11) > Created attachment 103194 [details] [review] [review] > Bug 25138: (follow-up) Point of sale should use library instead of branch > > Fixes a misssed occurence on the pay.tt page. > > To test: > - Don't have a cash register set up (or you have archived > the cash register for the library) > - Go to 'Point of sale' from the main staff interface page > - Verify library/branch in the note shown: > > You must have at least one cash register associated with > this library before you can record payments. > > https://bugs.koha-community.org/show_bug.cgi?id=24138 This has been pushed on Apr 17 commit 54630c842e800efefd95a4facf9907cd29a5b9cb