Unless I misunderstand the purpose of the AllowSelfCheckReturns system preference, I think it should be in the "Self check-in module" section of the Circulation system preferences. It is currently in the "Self Checkout" section.
Created attachment 103022 [details] [review] Bug 25147: AllowSelfCheckReturns is in the wrong system preference section This patch moves the AllowSelfCheckReturns system preference to the "Self check-in module" section of the Circulation system preferences. To test: 1) Check that the AllowSelfCheckReturns system preference is currently in the "Self Checkout" section of the Circulation system preferences. 2) Apply the patch 3) The preference should now be in the "Self check-in module" section of the Circulation system preferences.
Created attachment 103059 [details] [review] Bug 25147: AllowSelfCheckReturns is in the wrong system preference section This patch moves the AllowSelfCheckReturns system preference to the "Self check-in module" section of the Circulation system preferences. To test: 1) Check that the AllowSelfCheckReturns system preference is currently in the "Self Checkout" section of the Circulation system preferences. 2) Apply the patch 3) The preference should now be in the "Self check-in module" section of the Circulation system preferences. Signed-off-by: Devinim <kohadevinim@devinim.com.tr>
Created attachment 103069 [details] [review] Bug 25147: AllowSelfCheckReturns is in the wrong system preference section This patch moves the AllowSelfCheckReturns system preference to the "Self check-in module" section of the Circulation system preferences. To test: 1) Check that the AllowSelfCheckReturns system preference is currently in the "Self Checkout" section of the Circulation system preferences. 2) Apply the patch 3) The preference should now be in the "Self check-in module" section of the Circulation system preferences. Signed-off-by: Devinim <kohadevinim@devinim.com.tr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Everything currently in the chunk labelled "Self Checkout" is preferences used to control sco-main.pl, a feature that does checkout and renewal, and optionally with the preference AllSelfCheckReturns, also checkin. Everything currently in the chunk labelled "Self check-in module" is preferences used to control sci-main.pl, a separate feature that does only checkin, and does checkin whether or not AllowSelfCheckReturns is set. I'd think a better solution would be to either rename the preference, which is actually AllowReturnsInSelfCheckout, or rename the chunks to make it more clear that they are preferences for two different features.
Nice work everyone! Pushed to master for 20.05
(In reply to Phil Ringnalda from comment #4) > Everything currently in the chunk labelled "Self Checkout" is preferences > used to control sco-main.pl, a feature that does checkout and renewal, and > optionally with the preference AllSelfCheckReturns, also checkin. > > Everything currently in the chunk labelled "Self check-in module" is > preferences used to control sci-main.pl, a separate feature that does only > checkin, and does checkin whether or not AllowSelfCheckReturns is set. > > I'd think a better solution would be to either rename the preference, which > is actually AllowReturnsInSelfCheckout, or rename the chunks to make it more > clear that they are preferences for two different features Fair comment, I'd accept a followup to clarify the situation further.
On further consideration, I'm going to revert this patch from master and replace it with a quick followup to clarify the preference name as suggested by Phil.
Created attachment 103116 [details] [review] Bug 25147: Rename preference This patch renames the preference from the ambiguous 'AllowSelfCheckReturns' to 'SCOAllowCheckin' which is more consistent with other preferences affecting this module. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 103117 [details] [review] Bug 25147: Clarify section name Clarify the preference section headings for Self-checkout and Self-checkin. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Alternatives pushed :)
Created attachment 103120 [details] [review] Bug 25147: (RM follow-up) Update display I missed the display change in the preference name change.. oops. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 103121 [details] [review] Bug 25147: (RM follow-up) Update pref references. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
I made a right hash of that.. should all be good now.
enhancement not backported to 19.11.x