Hi, Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12913 solves the case when notforloan filter is not used, but it breaks the case when a filter is used. Regards Didier
Hi didier, when adding a new bug and you know where the problem comes from or which bug it's related to, you can use the "depends on" and "see also" to add a link. This will also make sure people on the other bug get an email :) Also the Importance preselects to enhancement - important to switch for bugs!
Can you detail how the bheaviour is broken?
Created attachment 105374 [details] [review] Bug 25167: Fix to a fix wrong inventory results Test plan : - Check you have in default framework an item subfield mapped with items.notforloan and with an authorized value catergory, for example 'NOTFORLOAN' - Create a new value in this category, for example '9' - Create a biblio with default framework - Create an item with barcode='000AAA1', callnumber='A-1' and notforloan=0 - Create an item with barcode='000AAA2', callnumber='A-2' and notforloan=9 - Create a file 'barecodes.txt' containing 2 lines '000AAA1' and '000AAA2' - Go to inventory tool : /cgi-bin/koha/tools/inventory.pl - Choose file in 'Barcode file' - Enter item callnumber between 'A-0' and 'A-9' - Check 'Compare barcodes list to results' - Submit=> without patch, you get no warnings - Redo the same inventory but with checking items.notforloan 'For loan' (using the browser back page is ok) - submit => still no warning, Bug 000AAA2 must be listed it's not 'For loan' - Apply patch, repeat, with tems.notforloan 'For loan' checked you get the right warning
I am looking at the code, but not understanding it well enough to see if this is the right fix. I wonder why we need no extra treatment for the other available checkbox options (withdrawn, lost and damaged). Leaving this for someone more familiar with inventory code in the QA team.
Hi, Other available checkbox options (withdrawn, lost and damaged) weren't in the list in the original functionality. This patch only restore the previous behaviour, at least I hope so. On the other hand not testing withdrawn, lost and so on doesn't seem to make sense. Regards Didier
Created attachment 112262 [details] [review] Bug 25167: Fix to a fix wrong inventory results Test plan : - Check you have in default framework an item subfield mapped with items.notforloan and with an authorized value catergory, for example 'NOTFORLOAN' - Create a new value in this category, for example '9' - Create a biblio with default framework - Create an item with barcode='000AAA1', callnumber='A-1' and notforloan=0 - Create an item with barcode='000AAA2', callnumber='A-2' and notforloan=9 - Create a file 'barecodes.txt' containing 2 lines '000AAA1' and '000AAA2' - Go to inventory tool : /cgi-bin/koha/tools/inventory.pl - Choose file in 'Barcode file' - Enter item callnumber between 'A-0' and 'A-9' - Check 'Compare barcodes list to results' - Submit=> without patch, you get no warnings - Redo the same inventory but with checking items.notforloan 'For loan' (using the browser back page is ok) - submit => still no warning, Bug 000AAA2 must be listed it's not 'For loan' - Apply patch, repeat, with tems.notforloan 'For loan' checked you get the right warning Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Behavior seems correct, now we have a warning on scanned barcode with a notforloan different from the one checked (on master, we just have a warning on the not scanned items). CSV export works fine. For what I saw, warning are still broken for the other 3 status Katrin mentioned.
Created attachment 112353 [details] [review] Bug 25167: (QA follow-up) Don't add a new variable
This fixes the issue mentioned, others should be on a new bug, there could be a lot of refactoring here to make this a bit more readable
Missing QA stamp.
Nick, can you fix your QA please?
Created attachment 112833 [details] [review] Bug 25167: Fix to a fix wrong inventory results Test plan : - Check you have in default framework an item subfield mapped with items.notforloan and with an authorized value catergory, for example 'NOTFORLOAN' - Create a new value in this category, for example '9' - Create a biblio with default framework - Create an item with barcode='000AAA1', callnumber='A-1' and notforloan=0 - Create an item with barcode='000AAA2', callnumber='A-2' and notforloan=9 - Create a file 'barecodes.txt' containing 2 lines '000AAA1' and '000AAA2' - Go to inventory tool : /cgi-bin/koha/tools/inventory.pl - Choose file in 'Barcode file' - Enter item callnumber between 'A-0' and 'A-9' - Check 'Compare barcodes list to results' - Submit=> without patch, you get no warnings - Redo the same inventory but with checking items.notforloan 'For loan' (using the browser back page is ok) - submit => still no warning, Bug 000AAA2 must be listed it's not 'For loan' - Apply patch, repeat, with tems.notforloan 'For loan' checked you get the right warning Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 112834 [details] [review] Bug 25167: (QA follow-up) Don't add a new variable Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 20.11, thanks to everybody involved!
backported to 20.05.x for 20.05.06
missing dependencies, not backported to 19.11.x