If you are editing a record and do a Z3950 search to replace you first get an alert you must confirm. On the details page the button simply says 'Replace via Z3950' Let's rename the button and avoid a click
Created attachment 103398 [details] [review] Bug 25231: Rename button instead of alert/confirm when replacing record This test plan applies to the basic editor only To test: 1 - Edit an existing record 2 - Click 'Z3950 Search' 3 - Note the confirmation box 4 - Add a new record 5 - Click 'Z3950 Search' 6 - Note no popup 7 - Apply patch 8 - Edit existing record 9 - Note button now says 'Replace record via Z3950 search' 10 - Add a new blank record 11 - Note the button says 'Z3950 search' 12 - Confirm editing/saving/replacing works as in the past
Works beautifully, thanks, but you left a stray "[%# Only ask for a confirmation if it is an edit %]" comment behind.
Created attachment 103401 [details] [review] Bug 25231: Rename button instead of alert/confirm when replacing record This test plan applies to the basic editor only To test: 1 - Edit an existing record 2 - Click 'Z3950 Search' 3 - Note the confirmation box 4 - Add a new record 5 - Click 'Z3950 Search' 6 - Note no popup 7 - Apply patch 8 - Edit existing record 9 - Note button now says 'Replace record via Z3950 search' 10 - Add a new blank record 11 - Note the button says 'Z3950 search' 12 - Confirm editing/saving/replacing works as in the past
Created attachment 103402 [details] [review] Bug 25231: Rename button instead of alert/confirm when replacing record This test plan applies to the basic editor only To test: 1 - Edit an existing record 2 - Click 'Z3950 Search' 3 - Note the confirmation box 4 - Add a new record 5 - Click 'Z3950 Search' 6 - Note no popup 7 - Apply patch 8 - Edit existing record 9 - Note button now says 'Replace record via Z3950 search' 10 - Add a new blank record 11 - Note the button says 'Z3950 search' 12 - Confirm editing/saving/replacing works as in the past Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Created attachment 103421 [details] [review] Bug 25231: Rename button instead of alert/confirm when replacing record This test plan applies to the basic editor only To test: 1 - Edit an existing record 2 - Click 'Z3950 Search' 3 - Note the confirmation box 4 - Add a new record 5 - Click 'Z3950 Search' 6 - Note no popup 7 - Apply patch 8 - Edit existing record 9 - Note button now says 'Replace record via Z3950 search' 10 - Add a new blank record 11 - Note the button says 'Z3950 search' 12 - Confirm editing/saving/replacing works as in the past Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: David Nind <david@davidnind.com>
Created attachment 103475 [details] [review] Bug 25231: Rename button instead of alert/confirm when replacing record This test plan applies to the basic editor only To test: 1 - Edit an existing record 2 - Click 'Z3950 Search' 3 - Note the confirmation box 4 - Add a new record 5 - Click 'Z3950 Search' 6 - Note no popup 7 - Apply patch 8 - Edit existing record 9 - Note button now says 'Replace record via Z3950 search' 10 - Add a new blank record 11 - Note the button says 'Z3950 search' 12 - Confirm editing/saving/replacing works as in the past Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Nice work everyone! Pushed to master for 20.05
Backported to 19.11.x for 19.11.06
backported to 19.05.x for 19.05.11