Library Catalogue - OPAC The ‘Author’ heading is not logical because it increases by more than one heading level. This means that screen reader users may not be able to determine the structure of content on the page. 1/ Search for an item 2/ Click through to a records full details disaply 3/ Note that the author details are semantically marked as a heading of the wrong level. Current Code: <h5 class="author">By: <a href="/cgi-bin/koha/opac- search.pl?q=au:%22Barty%2C%20James%22"><span resource="#record"><span property="author" typeof="Person"><span property="name">Barty, <span class="term">James</span></span></span></span></a><span class="separator"> | </span><a href="/cgi-bin/koha/opac-search.pl?q=au:%22Morgan%20Grenfell%22"><span resource="#record"><span property="author" typeof="Organization"><span property="name"><span class="term">Morgan</span> Grenfell</span></span></span></a>.</h5>
Created attachment 105737 [details] [review] Bug 25237: Fix semantic heading for opac-details Prior to this patch the opac-details view contained semantically incorrect h3 headings for the author information. Test plan 1/ Perform a search in the OPAC that will yield results 2/ Navigate to any results detailed view 3/ Inspect the page and note that there are semantically incorrect headings H1 (Page title) > H2 (Item title) > H5 (Author) 4/ Apply the patch 5/ Reload the page 6/ Inspect the page and note that the semantically incorrect author block has been converted to a span with an 'h3' class for styling 7/ Note the page still appears nicely 8/ Signoff Bonus points: Check with XSLT views enabled and disabled.
Created attachment 106182 [details] [review] Bug 25237: Fix semantic heading for opac-details Prior to this patch the opac-details view contained semantically incorrect h3 headings for the author information. Test plan 1/ Perform a search in the OPAC that will yield results 2/ Navigate to any results detailed view 3/ Inspect the page and note that there are semantically incorrect headings H1 (Page title) > H2 (Item title) > H5 (Author) 4/ Apply the patch 5/ Reload the page 6/ Inspect the page and note that the semantically incorrect author block has been converted to a span with an 'h3' class for styling 7/ Note the page still appears nicely 8/ Signoff Bonus points: Check with XSLT views enabled and disabled. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Created attachment 106619 [details] [review] Bug 25237: Fix semantic heading for opac-details Prior to this patch the opac-details view contained semantically incorrect h3 headings for the author information. Test plan 1/ Perform a search in the OPAC that will yield results 2/ Navigate to any results detailed view 3/ Inspect the page and note that there are semantically incorrect headings H1 (Page title) > H2 (Item title) > H5 (Author) 4/ Apply the patch 5/ Reload the page 6/ Inspect the page and note that the semantically incorrect author block has been converted to a span with an 'h3' class for styling 7/ Note the page still appears nicely 8/ Signoff Bonus points: Check with XSLT views enabled and disabled. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 20.11, thanks to everybody involved!
backported to 20.05.x for 20.05.03
backported to 19.11.x for 19.11.09
Not backported to oldoldstable (19.05.x). Feel free to ask if it's needed.