When renewing or editing the details of an expired patron via the "Renew" or "Edit details" links, there is a blank argument to "categorycode=". At a glance, it doesn't seem to cause problems, so we should either fix the argument, or remove the parameter.
I can change template to prevent empty 'categorycode=' from being added: [% IF categorycode %]&categorycode=[% categorycode | html %][% END %] After checking repository history and template stash I wasn't able to find any traces of 'categorycode' template parameter defined at all, in both /members/moremember.pl and /circ/circulations.pl, if that so, then we should remove `&categorycode=[% categorycode | html %]` from templates. If you can double check me and confirm that 'categorycode' not populated as template parameter in these perl files, then I propose for it's removal. I can commit the patch.
I confirm, that does not make sense. Coming from commit e193254e357e52f87e10f9b03e350781d2613062 Bug 22134: Add account expiration information to patron details
Created attachment 104418 [details] [review] Bug 25301: removed useless URI parameter "categorycode" from template Both "Edit details" links were sending empty query parameter "categorycode" as there is no such template parameter in "moremember.pl" defined at all, because template code block looks copy-pasted from "circulation.tt". This patch removes the parameter from "moremember.tt" template. To test: 1) You need to create or find expired or expiring patron. 2) Head to patron details page of that patron. 3) Inspect both "Edit details" links: one in the notification about expiration and other one in the "Expiration date:" field. 4) Observe empty parameter "categorycode=" in those links. 5) Apply patch. 6) Repeat step 3. 7) Check that there's no "categorycode=" in the links anymore.
Also I inspected "circulation.tt" template as well, as it has the same problem that "moremember.tt" had, link "Edit details" attempts to send parameter "categorycode" that is empty as it is not defined in "circulation.pl" same way it was not defined in "moremember.pl" I could not find any traces of how it appeared there before. Do you think it will be reasonable to remove it from "circulation.tt" as well as a separate patch or a new ticket?
Separate patch please :)
Created attachment 104484 [details] [review] Bug 25301: removed URI parameter "categorycode" from "circulation.tt" "Edit details" links in patron's circulation check-out page was sending empty query parameter "categorycode" because there is no defined template parameter in "circulation.pl" This patch removes the URI parameter from "circulation.tt" template. To test: 1) You need to create or find expired or expiring patron. 2) Head to patron's circulation check-out page. 3) Inspect "Edit details" link. 4) Observe empty parameter "categorycode=" in that link. 5) Apply patch. 6) Repeat step 3. 7) Check that there's no "categorycode=" in the link anymore.
Created attachment 104630 [details] [review] Bug 25301: removed useless URI parameter "categorycode" from template Both "Edit details" links were sending empty query parameter "categorycode" as there is no such template parameter in "moremember.pl" defined at all, because template code block looks copy-pasted from "circulation.tt". This patch removes the parameter from "moremember.tt" template. To test: 1) You need to create or find expired or expiring patron. 2) Head to patron details page of that patron. 3) Inspect both "Edit details" links: one in the notification about expiration and other one in the "Expiration date:" field. 4) Observe empty parameter "categorycode=" in those links. 5) Apply patch. 6) Repeat step 3. 7) Check that there's no "categorycode=" in the links anymore. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 104631 [details] [review] Bug 25301: removed URI parameter "categorycode" from "circulation.tt" "Edit details" links in patron's circulation check-out page was sending empty query parameter "categorycode" because there is no defined template parameter in "circulation.pl" This patch removes the URI parameter from "circulation.tt" template. To test: 1) You need to create or find expired or expiring patron. 2) Head to patron's circulation check-out page. 3) Inspect "Edit details" link. 4) Observe empty parameter "categorycode=" in that link. 5) Apply patch. 6) Repeat step 3. 7) Check that there's no "categorycode=" in the link anymore. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 104656 [details] [review] Bug 25301: removed useless URI parameter "categorycode" from template Both "Edit details" links were sending empty query parameter "categorycode" as there is no such template parameter in "moremember.pl" defined at all, because template code block looks copy-pasted from "circulation.tt". This patch removes the parameter from "moremember.tt" template. To test: 1) You need to create or find expired or expiring patron. 2) Head to patron details page of that patron. 3) Inspect both "Edit details" links: one in the notification about expiration and other one in the "Expiration date:" field. 4) Observe empty parameter "categorycode=" in those links. 5) Apply patch. 6) Repeat step 3. 7) Check that there's no "categorycode=" in the links anymore. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 104657 [details] [review] Bug 25301: removed URI parameter "categorycode" from "circulation.tt" "Edit details" links in patron's circulation check-out page was sending empty query parameter "categorycode" because there is no defined template parameter in "circulation.pl" This patch removes the URI parameter from "circulation.tt" template. To test: 1) You need to create or find expired or expiring patron. 2) Head to patron's circulation check-out page. 3) Inspect "Edit details" link. 4) Observe empty parameter "categorycode=" in that link. 5) Apply patch. 6) Repeat step 3. 7) Check that there's no "categorycode=" in the link anymore. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 104658 [details] [review] Bug 25301: removed URI parameter "categorycode" from the toolbar Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Nice work everyone! Pushed to master for 20.05
Pushed to 19.11.x for 19.11.06