Bug 25302 - The indentations should be in accordance with the Coding guidelines and whitespaces/linebreaks should be consistent.
Summary: The indentations should be in accordance with the Coding guidelines and white...
Status: CLOSED INVALID
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Timothy Alexis Vass
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-28 11:14 UTC by Timothy Alexis Vass
Modified: 2020-11-30 21:45 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
=== Indentations are now consistently 4 spaces and opening/closing tags are now aligned. === example: <div id="html5media"> [% FOREACH ... %] <p> ... </p> [% END %] </div> is now: <div id="html5media"> (131.56 KB, text/plain)
2020-04-28 14:44 UTC, Timothy Alexis Vass
Details
Bug 25302: The indentations should be in accordance with the Coding guidelines and whitespaces/linebreaks should be consistent. (130.58 KB, patch)
2020-04-30 09:40 UTC, Timothy Alexis Vass
Details | Diff | Splinter Review
Bug 25302: The indentations should be in accordance with the Coding guidelines and whitespaces/linebreaks should be consistent. (120.99 KB, patch)
2020-04-30 12:22 UTC, Timothy Alexis Vass
Details | Diff | Splinter Review
Bug 25302: The indentations should be in accordance with the Coding guidelines and whitespaces/linebreaks should be consistent. (120.99 KB, patch)
2020-04-30 14:07 UTC, Timothy Alexis Vass
Details | Diff | Splinter Review
Bug 25302: The indentations should be in accordance with the Coding guidelines and whitespaces/linebreaks should be consistent. (1.25 KB, patch)
2020-05-04 14:51 UTC, Timothy Alexis Vass
Details | Diff | Splinter Review
Bug 25302: The indentations should be in accordance with the Coding guidelines and whitespaces/linebreaks should be consistent. (120.48 KB, patch)
2020-05-04 15:00 UTC, Timothy Alexis Vass
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Alexis Vass 2020-04-28 11:14:35 UTC
Simply put, the indentations are inconsistent.
Comment 1 Timothy Alexis Vass 2020-04-28 14:44:38 UTC
Created attachment 103863 [details]
=== Indentations are now consistently 4 spaces and opening/closing tags are now aligned. === example:     <div id="html5media">       [% FOREACH ... %]         <p>           ...         </p>       [% END %]     </div> is now:     <div id="html5media">

===
Whitespaces are now consistent
===
1. Occuring > < and ] [ changed to >< and ][
    example:
        <li> <a href="...
    is now:
        <li><a href="...

2. Occuring \S%] changed to \S %]
    example:
        ELSE%]
    is now:
        ELSE %]

3. Occuring # /\S changed to # / \S
    example:
        [% # /IF
    is now
        [% # / IF

4. Sometimes empty lines between concurrent [% IF %] statements changed to always
    example:
        [% END %]
        [% IF ...
    is now:
        [% END %]

        [% IF ...

5. Occuring ,\S changed to , \S
    example:
        function(d,s,id)
    is now:
        function(d, s, id)

6. Occuring IF \(\S.+\S\) changed to IF \( \S.+\S\ )
    example:
        IF (SeparateHoldings)
    is now:
        IF ( SeparateHoldings )
Comment 2 Timothy Alexis Vass 2020-04-28 14:46:03 UTC
Seems like the first part of the comment was different from the commit message, it should be:
===
Indentations are now consistently 4 spaces and otherwise correct
===
example:
    <div id="html5media">
      [% FOREACH ... %]
        <p>
          ...
        </p>
      [% END %]
    </div>
is now:
    <div id="html5media">
        [% FOREACH ... %]
            <p>
                ...
            </p>
        [% END %]
    </div>
Comment 3 Owen Leonard 2020-04-28 16:42:37 UTC
I'm marking this "Failed QA" so that this patch can wait for an amended commit message as we discussed on IRC.
Comment 4 Timothy Alexis Vass 2020-04-30 09:40:26 UTC
Created attachment 104010 [details] [review]
Bug 25302: The indentations should be in accordance with the Coding guidelines and whitespaces/linebreaks should be consistent.

    To test:
    1) Open an item in OPAC and see if it works.
Comment 5 Timothy Alexis Vass 2020-04-30 12:22:31 UTC
Created attachment 104029 [details] [review]
Bug 25302: The indentations should be in accordance with the Coding guidelines and whitespaces/linebreaks should be consistent.

    To test:
    1) Open an item in OPAC and see if it works.
Comment 6 Timothy Alexis Vass 2020-04-30 14:07:08 UTC
Created attachment 104036 [details] [review]
Bug 25302: The indentations should be in accordance with the Coding guidelines and whitespaces/linebreaks should be consistent.

    To test:
    1) Open an item in OPAC and see if it works.
Comment 7 Timothy Alexis Vass 2020-05-04 14:51:37 UTC
Created attachment 104299 [details] [review]
Bug 25302: The indentations should be in accordance with the Coding guidelines and whitespaces/linebreaks should be consistent.

    To test:
    1) Open an item in OPAC and see if it works.
Comment 8 Timothy Alexis Vass 2020-05-04 15:00:10 UTC
Created attachment 104301 [details] [review]
Bug 25302: The indentations should be in accordance with the Coding guidelines and whitespaces/linebreaks should be consistent.

    To test:
    1) Open an item in OPAC and see if it works.
Comment 9 Katrin Fischer 2020-05-05 08:01:25 UTC
Hi Timothy, what happened here? Keen on helping you to get a patch in, catch me on IRC if you need any help.