Created attachment 103889 [details] Sandbox Error Trace Log On master, it is not possible to create patrons. You get an error Can't call method "extended_attributes" on an undefined value at /kohadevbox/koha/members/memberentry.pl line 560 This happens whether you populate the delivered extended attribute (SHOW_BCODE) or not. I have reproduced this on my own dev server, and on the Sandboxes. I've attached the error trace log from the sandboxes.
The real error was lost in the log file: "Data too long for column 'streetnumber'"
Created attachment 103933 [details] [review] Bug 25309: Limit size of streetnumber field to 10 It's its size in DB (varchar(10)) Test plan: Create or editing a patron and confirm that you fill in more than 10 characters in the streetnumber field Save => The patron has been correctly created/updated
Created attachment 103956 [details] [review] Bug 25309: Limit size of streetnumber field to 10 It's its size in DB (varchar(10)) Test plan: Create or editing a patron and confirm that you fill in more than 10 characters in the streetnumber field Save => The patron has been correctly created/updated Signed-off-by: David Roberts <david@koha-ptfs.co.uk>
We should probably also disable autofill on this form here perhaps? I think the original issue was found due to an erroneous autofill.
Created attachment 104159 [details] [review] Bug 25309: Limit size of streetnumber field to 10 It's its size in DB (varchar(10)) Test plan: Create or editing a patron and confirm that you fill in more than 10 characters in the streetnumber field Save => The patron has been correctly created/updated Signed-off-by: David Roberts <david@koha-ptfs.co.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Nice work everyone! Pushed to master for 20.05
not backported to 19.11. will try again if 25311 is rebased.
(In reply to Joy Nelson from comment #7) > not backported to 19.11. will try again if 25311 is rebased. Apply cleanly on top of the 19.11.x rebased patches from bug 25311.
backported to 19.11.x for 19.11.06
Can't be backported to 19.05.x due to dependence on bug 25311. So if someone is interested in this bug being backported to 19.05.x, send help to bug 25311 ^^