To recreate: - Edit your default framework, connect any subfield outside of the 952 to an authorised value (for example, connect the 942$n to the Yes_No auth value) - Find a record in that framework - Edit the record and find your subfield - The subfield shows a dropdown with no contents - check plack log, see "DBD::mysql::st execute failed: 'koha_kohadev.authorised_values.authorised_value' isn't in GROUP BY "
Created attachment 104051 [details] [review] Bug 25335: group by authorised_value in addbiblio.pl To Test: 1- Edit your default framework, connect any subfield outside of the 952 to an authorised value (for example, connect the 942$n to the Yes_No auth value) 2 - Find a record in that framework 3 - Edit the record and find your subfield 4 - The subfield shows a dropdown with no contents 5 - check plack log, see "DBD::mysql::st execute failed: 'koha_kohadev.authorised_values.authorised_value' isn't in GROUP BY " 6 - apply patch, restart all 7 - reload edit record page, see your auth value dropdown has contents
Created attachment 104077 [details] [review] Bug 25335: group by authorised_value in addbiblio.pl To Test: 1- Edit your default framework, connect any subfield outside of the 952 to an authorised value (for example, connect the 942$n to the Yes_No auth value) 2 - Find a record in that framework 3 - Edit the record and find your subfield 4 - The subfield shows a dropdown with no contents 5 - check plack error log, see "DBD::mysql::st execute failed: 'koha_kohadev.authorised_values.authorised_value' isn't in GROUP BY " 6 - apply patch, restart all 7 - reload edit record page, see your auth value dropdown has contents Signed-off-by: David Nind <david@davidnind.com>
Created attachment 104231 [details] [review] Bug 25335: group by authorised_value in addbiblio.pl To Test: 1- Edit your default framework, connect any subfield outside of the 952 to an authorised value (for example, connect the 942$n to the Yes_No auth value) 2 - Find a record in that framework 3 - Edit the record and find your subfield 4 - The subfield shows a dropdown with no contents 5 - check plack log, see "DBD::mysql::st execute failed: 'koha_kohadev.authorised_values.authorised_value' isn't in GROUP BY " 6 - apply patch, restart all 7 - reload edit record page, see your auth value dropdown has contents Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Good catch!
Nice work everyone! Pushed to master for 20.05
Backported to 19.11.x for 19.11.06
backported to 19.05.x for 19.05.11