Hello! I noticed that the Show checkouts to guarantor and Show fines to guarantor flags are in the "Library use" section of the patron file. However, they are set in the "Contact information" section with the setting of the guarantor. This is confusing because if you want to edit the flags, you cannot do it by clicking the "Edit" button next to "Library use", even though the flags are in that section. You have to know that they are set in the "Contact information" section and use that "Edit" button to change them. Caroline
I was going to create an entirely new section for Guarantor information, from which you could edit just the guarantor/guarantee, but I found I was introducing bugs faster than I could fix them! Instead, I've simply moved the two fields from the Library Use section into the Contact section so that they are now in the same section as where they get edited.
Created attachment 104243 [details] [review] Bug 25336: Show checkouts/fines to guarantor is in the wrong section of the patron file This patch moves the "Show checkouts to guarantor" and "Show fines to guarantor" data to display under the Contact information block To test: 1) Enable the AllowStaffToSetCheckoutsVisibilityForGuarantor and AllowStaffToSetFinesVisibilityForGuarantor system preferences to Allow 2) View a patron record. 3) The "Show checkouts to guarantor" and "Show fines to guarantor" field will be on the right hand side of the screen under the Library use block. 4) Apply patch 5) Check that this data has now moved to the Contact information block on the left hand side of the patron record.
Created attachment 106665 [details] [review] Bug 25336: Show checkouts/fines to guarantor is in the wrong section of the patron file This patch moves the "Show checkouts to guarantor" and "Show fines to guarantor" data to display under the Contact information block To test: 1) Enable the AllowStaffToSetCheckoutsVisibilityForGuarantor and AllowStaffToSetFinesVisibilityForGuarantor system preferences to Allow 2) View a patron record. 3) The "Show checkouts to guarantor" and "Show fines to guarantor" field will be on the right hand side of the screen under the Library use block. 4) Apply patch 5) Check that this data has now moved to the Contact information block on the left hand side of the patron record. Works for me! Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Created attachment 107901 [details] [review] Bug 25336: Show checkouts/fines to guarantor is in the wrong section of the patron file This patch moves the "Show checkouts to guarantor" and "Show fines to guarantor" data to display under the Contact information block To test: 1) Enable the AllowStaffToSetCheckoutsVisibilityForGuarantor and AllowStaffToSetFinesVisibilityForGuarantor system preferences to Allow 2) View a patron record. 3) The "Show checkouts to guarantor" and "Show fines to guarantor" field will be on the right hand side of the screen under the Library use block. 4) Apply patch 5) Check that this data has now moved to the Contact information block on the left hand side of the patron record. Works for me! Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 20.11, thanks to everybody involved!
backported to 20.05.x for 20.05.03
backported to 19.11.x for 19.11.09
Not backported to oldoldstable (19.05.x). Feel free to ask if it's needed.