When editing a subfield, there is: Max length: XXXX (see online help) We should either link to the online help or remove it. koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt: <li><label for="maxlength[% loo.row | html %]">Max length:</label><input type="text" id="maxlength[% loo.row | html %]" name="maxlength" value="[% loo.maxlength | html %]" size="4" /> (see online help)</li>
There is actually nothing in the online help about this (as far as I can see) so I think it is best to remove it. It seems fairly self explanatory anyway, and I don't see what other information the online help could provide.
+1
Created attachment 104514 [details] [review] Bug 25288: (follow-up) Use .escapeHtml() Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Wrong bug
Created attachment 104532 [details] [review] Bug 25388: There is no link for the "online help" This patch removes a non-existent link to the online help from the marc subfield editor. To test: 1) Go to Admin > MARC Bibliographic framework > Edit MARC structure > Edit subfield (for example /cgi-bin/koha/admin/marc_subfields_structure.pl?op=add_form&tagfield=000&frameworkcode=AR) 2) Check that the Max Length value in the Advanced constraints area contains text saying "See online help" 3) Apply patch 4) Check that the reference to the online help has disappeared.
Looks fine but fails QA tool: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt OK filters FAIL forbidden patterns forbidden pattern: tab char (line 131) OK git manipulation OK js_in_body OK spelling OK tt_valid OK valid_template I see this happen when I cut and paste sometimes.
(In reply to Lucas Gass from comment #6) > Looks fine but fails QA tool: > > FAIL > koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt > OK filters > FAIL forbidden patterns > forbidden pattern: tab char (line 131) > OK git manipulation > OK js_in_body > OK spelling > OK tt_valid > OK valid_template > > > I see this happen when I cut and paste sometimes. That's odd - I deleted data from the end of that line, I didn't copy and paste anything! I think this might have been a 'legacy tab" from a previous edit in the past. I've removed it now anyway, so changed back to Needs Signoff
Created attachment 104543 [details] [review] Bug 25388: There is no link for the "online help" This patch removes a non-existent link to the online help from the marc subfield editor. To test: 1) Go to Admin > MARC Bibliographic framework > Edit MARC structure > Edit subfield (for example /cgi-bin/koha/admin/marc_subfields_structure.pl?op=add_form&tagfield=000&frameworkcode=AR) 2) Check that the Max Length value in the Advanced constraints area contains text saying "See online help" 3) Apply patch 4) Check that the reference to the online help has disappeared. Remove tabs from start of line
Created attachment 104553 [details] [review] Bug 25388: There is no link for the "online help" This patch removes a non-existent link to the online help from the marc subfield editor. To test: 1) Go to Admin > MARC Bibliographic framework > Edit MARC structure > Edit subfield (for example /cgi-bin/koha/admin/marc_subfields_structure.pl?op=add_form&tagfield=000&frameworkcode=AR) 2) Check that the Max Length value in the Advanced constraints area contains text saying "See online help" 3) Apply patch 4) Check that the reference to the online help has disappeared. Remove tabs from start of line Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Removing a little bit of text - setting to PQA directly. Thx David!
Nice work everyone! Pushed to master for 20.05
Backported to 19.11.x for 19.11.06
backported to 19.05.x for 19.05.11