Bug 2539 - kohaspsuggest is deprecated, notes outmoded
Summary: kohaspsuggest is deprecated, notes outmoded
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: master
Hardware: All All
: PATCH-Sent (DO NOT USE) normal (vote)
Assignee: Owen Leonard
QA Contact:
URL:
Keywords:
Depends on:
Blocks: 36224
  Show dependency treegraph
 
Reported: 2008-08-20 11:53 UTC by Chris Cormack
Modified: 2024-03-05 15:56 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed fix (10.36 KB, patch)
2011-08-22 20:11 UTC, Owen Leonard
Details | Diff | Splinter Review
Fix for Bug 2539 - kohaspsuggest is deprecated, notes outmoded (10.37 KB, patch)
2011-09-02 03:14 UTC, Robin Sheat
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 00:52:21 UTC


---- Reported by joe.atzberger@liblime.com 2008-08-20 11:53:38 ----

The syspref "kohaspsuggest" is for an external database, but this feature does not appear functional in 3.0.   Reportedly it did something in 2.4(?) according to notes in the script:
  misc/spellcheck_suggest/make_spellcheck_suggest.pl

But the script doesn't actually make use of the system preference and instead expects you to hand edit it.  The searches (opac/opac-search.pl and catalogue/search.pl) use the syspref, but there doesn't appear to be any instruction on how to setup this additional DB.  The same notes reference http://liblime.com/c/downloads.html but currently that resolves only to a 404.  

I suggest we change the syspref description(s) to designate kohaspsuggest as "[UNIMPLEMENTED]" for now and rework the script later, if necessary.  Script comments (URL) should be corrected or removed.

There may be related documentation updates also.

More broadly, I don't understand the motivation to use a separate database to begin with.  Wouldn't a table in the Koha DB be sufficient?  Is it just a performance/load distribution question?  Or is the intention to share one such DB amongst many koha installations (i.e., different permissions model)?



---- Additional Comments From joe.atzberger@liblime.com 2009-07-02 03:51:01 ----

Sent a patch removing spsuggest logic from search scripts.  More needs to be done to purge this though.



---- Additional Comments From gmcharlt@gmail.com 2009-07-15 01:22:38 ----

Pushed patch removing spsuggest references from the search scripts to HEAD.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 00:52 UTC  ---

This bug was previously known as _bug_ 2539 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2539

Actual time not defined. Setting to 0.0
The original reporter of this bug does not have
   an account here. Reassigning to the person who moved
   it here: chris@bigballofwax.co.nz.
   Previous reporter was joe.atzberger@liblime.com.
CC member benide@gmail.com does not have an account here
CC member dianajweaver@gmail.com does not have an account here

Comment 1 Owen Leonard 2011-05-17 18:15:56 UTC
I don't find any instances to "kohaspsuggest" anymore. Is removing /misc/spellcheck_suggest/make_spellcheck_suggest.pl the only thing left to do?
Comment 2 Owen Leonard 2011-08-22 20:11:48 UTC Comment hidden (obsolete)
Comment 3 Robin Sheat 2011-09-02 03:14:27 UTC
Created attachment 5265 [details] [review]
Fix for Bug 2539 - kohaspsuggest is deprecated, notes outmoded

Removing unused script.

Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
Comment 4 Ian Walls 2011-09-02 03:48:54 UTC
Deletes an unused script, easy to read, marking as Passed QA
Comment 5 Chris Cormack 2011-09-02 18:28:42 UTC
Pushed, please test
Comment 6 Chris Nighswonger 2011-10-26 18:02:24 UTC
The fix for this bug was published in the 3.4.5 release. If you were the reporter of this bug, please take time to verify the fix and update the status of this bug report accordingly. If the bug is fixed to your satisfaction, please close this report.
Comment 7 Jared Camins-Esakov 2012-12-31 00:59:36 UTC
There have been no further reports of problems so I am marking this bug resolved.