Bug 25393 - Create separate 'no automatic renewal before' rule
Summary: Create separate 'no automatic renewal before' rule
Status: Needs documenting
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Pedro Amorim
QA Contact: Nick Clemens
URL:
Keywords:
: 22018 35735 (view as bug list)
Depends on:
Blocks: 34526 36021
  Show dependency treegraph
 
Reported: 2020-05-06 16:16 UTC by Andrew Fuerste-Henry
Modified: 2024-02-08 14:21 UTC (History)
16 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This new circulation rule allows libraries to control the no renewal before behaviour at the auto and non-auto renewals level.
Version(s) released in:
23.11.00


Attachments
Bug 25393: Add new noautorenewalbefore circulation rule (8.39 KB, patch)
2023-08-17 11:09 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 25393: Use new noautorenewalbefore circulation rule in _CanBookBeAutoRenewed (768 bytes, patch)
2023-08-17 11:09 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 25393: UI adjustments (8.35 KB, patch)
2023-08-17 11:09 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 25393: Distinguish between auto or normal renewals in GetSoonestRenewDate (3.21 KB, patch)
2023-08-17 11:09 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 25393: atomicupdate file (2.08 KB, patch)
2023-08-17 11:09 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 25393: Auto renewals logic reimplementation: (1.77 KB, patch)
2023-08-17 11:09 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 25393: Update CanBookBeRenewed pod with bug 25758 changes (1.15 KB, patch)
2023-08-17 11:09 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 25393: Tests - Variable renaming (8.98 KB, patch)
2023-08-17 11:09 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 25393: Update Circulation.t (13.75 KB, patch)
2023-08-17 11:09 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 25393: Add new noautorenewalbefore circulation rule (8.45 KB, patch)
2023-08-18 15:50 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 25393: Use new noautorenewalbefore circulation rule in _CanBookBeAutoRenewed (830 bytes, patch)
2023-08-18 15:50 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 25393: UI adjustments (8.42 KB, patch)
2023-08-18 15:50 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 25393: Distinguish between auto or normal renewals in GetSoonestRenewDate (3.27 KB, patch)
2023-08-18 15:50 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 25393: atomicupdate file (2.14 KB, patch)
2023-08-18 15:50 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 25393: Auto renewals logic reimplementation: (1.83 KB, patch)
2023-08-18 15:50 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 25393: Update CanBookBeRenewed pod with bug 25758 changes (1.21 KB, patch)
2023-08-18 15:50 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 25393: Tests - Variable renaming (9.04 KB, patch)
2023-08-18 15:50 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 25393: Update Circulation.t (13.81 KB, patch)
2023-08-18 15:50 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 25393: Add new noautorenewalbefore circulation rule (8.45 KB, patch)
2023-09-07 14:43 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 25393: Use new noautorenewalbefore circulation rule in _CanBookBeAutoRenewed (828 bytes, patch)
2023-09-07 14:43 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 25393: UI adjustments (8.41 KB, patch)
2023-09-07 14:43 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 25393: Distinguish between auto or normal renewals in GetSoonestRenewDate (3.24 KB, patch)
2023-09-07 14:43 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 25393: atomicupdate file (2.14 KB, patch)
2023-09-07 14:44 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 25393: Auto renewals logic reimplementation: (1.83 KB, patch)
2023-09-07 14:44 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 25393: Update CanBookBeRenewed pod with bug 25758 changes (1.21 KB, patch)
2023-09-07 14:44 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 25393: Tests - Variable renaming (9.04 KB, patch)
2023-09-07 14:44 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 25393: Update Circulation.t (13.88 KB, patch)
2023-09-07 14:44 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 25393: Add new noautorenewalbefore circulation rule (8.50 KB, patch)
2023-10-11 14:56 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 25393: Use new noautorenewalbefore circulation rule in _CanBookBeAutoRenewed (884 bytes, patch)
2023-10-11 14:56 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 25393: UI adjustments (8.47 KB, patch)
2023-10-11 14:56 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 25393: Distinguish between auto or normal renewals in GetSoonestRenewDate (3.27 KB, patch)
2023-10-11 14:56 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 25393: atomicupdate file (2.20 KB, patch)
2023-10-11 14:56 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 25393: Auto renewals logic reimplementation: (1.88 KB, patch)
2023-10-11 14:56 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 25393: Update CanBookBeRenewed pod with bug 25758 changes (1.26 KB, patch)
2023-10-11 14:56 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 25393: Tests - Variable renaming (9.08 KB, patch)
2023-10-11 14:56 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 25393: Update Circulation.t (13.91 KB, patch)
2023-10-11 14:56 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 25393: (QA follow-up) Report 'too_soon' errors from cron (1.29 KB, patch)
2023-10-11 14:56 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 25393: (QA follow-up) simplify auto_renew condition (1.35 KB, patch)
2023-10-11 14:56 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 25393: (QA follow-up) Tidy (20.16 KB, patch)
2023-10-11 14:56 UTC, Nick Clemens
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Fuerste-Henry 2020-05-06 16:16:54 UTC
Koha currently applies the No Renewal Before value to both manual and automatic renewal. Libraries that use a mix of manual and automatic renewal often don't want the same behavior between them - they want manual renewal to be possible earlier in the checkout even if automatic renewal doesn't happen until closer to the due date. We could address this by maintaining separate No Renewal Before values.

For what it's worth, we already acknowledge this possibility when leaving No Renewal Before blank. For a manual renewal, no value in No Renewal Before allows renewal immediately. For an automatic renewal, no value in No Renewal Before does not allow renewal until the due date.
Comment 1 kate 2022-12-07 17:09:45 UTC
Strong agreement on this! We are currently struggling with autorenewal - we left "No Renewal Before" blank to keep the Never Autorenew people happy but now autorenew people are getting a glitchy notice after the autorenew notice and they're confused. We're going to try tipping the balance back to irritating the Never Autorenew people but I'd love to see this development happen.
Comment 2 Kelly McElligott 2023-08-17 08:55:47 UTC
Testing Plan

1. Ensure that there is a new column in the circulation and rule matrix for "No Automatic Renewal Before"
2. To test this process, a few rules will need to be tested to ensure that staff/patrons have the option to renew - even if the item is set to auto-renewal. 3. Use values such as  No renewal before= 2 and No Auto Renewal = 3
4. Ensure that the patron can renew the item that is set to Auto Renew if they are within the date range of renewability (set up by the No Renew/No Auto Renew column values). If the item is too early to renew, ensure that it gives a date and also states that this item is set to automatically renew.
5. Try values such as No Renewal before =2 and No Auto Renewal =1, Ensure that the patron can renew the item that is set to Auto Renew if they are within the date range of renewability (set up by the No Renew/No Auto Renew column values). If the item is too early to renew, ensure that it gives a date and also states that this item is set to automatically renew.
6 Now go to the SCO and make sure the patron can renew items that are eligible to renew and if not, make sure patrons can see that they are scheduled to auto-renew.
Comment 3 Pedro Amorim 2023-08-17 11:09:10 UTC
Created attachment 154533 [details] [review]
Bug 25393: Add new noautorenewalbefore circulation rule
Comment 4 Pedro Amorim 2023-08-17 11:09:13 UTC
Created attachment 154534 [details] [review]
Bug 25393: Use new noautorenewalbefore circulation rule in _CanBookBeAutoRenewed
Comment 5 Pedro Amorim 2023-08-17 11:09:16 UTC
Created attachment 154535 [details] [review]
Bug 25393: UI adjustments

This updates the information messages that are displayed in Staff, OPAC and SCO
regarding renewals and if the item is up for automatic renewal or not.

Add issues.auto_renew to svc/checkouts endpoint response
Comment 6 Pedro Amorim 2023-08-17 11:09:19 UTC
Created attachment 154536 [details] [review]
Bug 25393: Distinguish between auto or normal renewals in GetSoonestRenewDate
Comment 7 Pedro Amorim 2023-08-17 11:09:22 UTC
Created attachment 154537 [details] [review]
Bug 25393: atomicupdate file
Comment 8 Pedro Amorim 2023-08-17 11:09:25 UTC
Created attachment 154538 [details] [review]
Bug 25393: Auto renewals logic reimplementation:

Check if it's too soon for a manual renewal  even if 'Automatic renewals' is enabled
Allow for a manual renewal even if it's too soon for an automatic renewal
Comment 9 Pedro Amorim 2023-08-17 11:09:29 UTC
Created attachment 154539 [details] [review]
Bug 25393: Update CanBookBeRenewed pod with bug 25758 changes
Comment 10 Pedro Amorim 2023-08-17 11:09:32 UTC
Created attachment 154540 [details] [review]
Bug 25393: Tests - Variable renaming

issue_4 is an auto_renew issue, rename to auto_renew_issue
Comment 11 Pedro Amorim 2023-08-17 11:09:35 UTC
Created attachment 154541 [details] [review]
Bug 25393: Update Circulation.t

prove t/db_dependent/Circulation.t
Comment 12 Andrew Fuerste-Henry 2023-08-18 15:50:05 UTC
Created attachment 154661 [details] [review]
Bug 25393: Add new noautorenewalbefore circulation rule

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 13 Andrew Fuerste-Henry 2023-08-18 15:50:08 UTC
Created attachment 154662 [details] [review]
Bug 25393: Use new noautorenewalbefore circulation rule in _CanBookBeAutoRenewed

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 14 Andrew Fuerste-Henry 2023-08-18 15:50:11 UTC
Created attachment 154663 [details] [review]
Bug 25393: UI adjustments

This updates the information messages that are displayed in Staff, OPAC and SCO
regarding renewals and if the item is up for automatic renewal or not.

Add issues.auto_renew to svc/checkouts endpoint response

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 15 Andrew Fuerste-Henry 2023-08-18 15:50:14 UTC
Created attachment 154664 [details] [review]
Bug 25393: Distinguish between auto or normal renewals in GetSoonestRenewDate

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 16 Andrew Fuerste-Henry 2023-08-18 15:50:17 UTC
Created attachment 154665 [details] [review]
Bug 25393: atomicupdate file

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 17 Andrew Fuerste-Henry 2023-08-18 15:50:20 UTC
Created attachment 154666 [details] [review]
Bug 25393: Auto renewals logic reimplementation:

Check if it's too soon for a manual renewal  even if 'Automatic renewals' is enabled
Allow for a manual renewal even if it's too soon for an automatic renewal

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 18 Andrew Fuerste-Henry 2023-08-18 15:50:23 UTC
Created attachment 154667 [details] [review]
Bug 25393: Update CanBookBeRenewed pod with bug 25758 changes

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 19 Andrew Fuerste-Henry 2023-08-18 15:50:25 UTC
Created attachment 154668 [details] [review]
Bug 25393: Tests - Variable renaming

issue_4 is an auto_renew issue, rename to auto_renew_issue

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 20 Andrew Fuerste-Henry 2023-08-18 15:50:28 UTC
Created attachment 154669 [details] [review]
Bug 25393: Update Circulation.t

prove t/db_dependent/Circulation.t

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 21 Pedro Amorim 2023-09-01 09:27:03 UTC
This needs a rebase on top of bug 30362.
Comment 22 Pedro Amorim 2023-09-07 14:43:49 UTC
Created attachment 155307 [details] [review]
Bug 25393: Add new noautorenewalbefore circulation rule

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 23 Pedro Amorim 2023-09-07 14:43:52 UTC
Created attachment 155308 [details] [review]
Bug 25393: Use new noautorenewalbefore circulation rule in _CanBookBeAutoRenewed

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 24 Pedro Amorim 2023-09-07 14:43:56 UTC
Created attachment 155309 [details] [review]
Bug 25393: UI adjustments

This updates the information messages that are displayed in Staff, OPAC and SCO
regarding renewals and if the item is up for automatic renewal or not.

Add issues.auto_renew to svc/checkouts endpoint response

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 25 Pedro Amorim 2023-09-07 14:43:59 UTC
Created attachment 155310 [details] [review]
Bug 25393: Distinguish between auto or normal renewals in GetSoonestRenewDate

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 26 Pedro Amorim 2023-09-07 14:44:03 UTC
Created attachment 155311 [details] [review]
Bug 25393: atomicupdate file

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 27 Pedro Amorim 2023-09-07 14:44:06 UTC
Created attachment 155312 [details] [review]
Bug 25393: Auto renewals logic reimplementation:

Check if it's too soon for a manual renewal  even if 'Automatic renewals' is enabled
Allow for a manual renewal even if it's too soon for an automatic renewal

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 28 Pedro Amorim 2023-09-07 14:44:09 UTC
Created attachment 155313 [details] [review]
Bug 25393: Update CanBookBeRenewed pod with bug 25758 changes

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 29 Pedro Amorim 2023-09-07 14:44:13 UTC
Created attachment 155314 [details] [review]
Bug 25393: Tests - Variable renaming

issue_4 is an auto_renew issue, rename to auto_renew_issue

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 30 Pedro Amorim 2023-09-07 14:44:16 UTC
Created attachment 155315 [details] [review]
Bug 25393: Update Circulation.t

prove t/db_dependent/Circulation.t

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 31 Nick Clemens 2023-10-11 14:56:15 UTC
Created attachment 156829 [details] [review]
Bug 25393: Add new noautorenewalbefore circulation rule

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 32 Nick Clemens 2023-10-11 14:56:18 UTC
Created attachment 156830 [details] [review]
Bug 25393: Use new noautorenewalbefore circulation rule in _CanBookBeAutoRenewed

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 33 Nick Clemens 2023-10-11 14:56:21 UTC
Created attachment 156831 [details] [review]
Bug 25393: UI adjustments

This updates the information messages that are displayed in Staff, OPAC and SCO
regarding renewals and if the item is up for automatic renewal or not.

Add issues.auto_renew to svc/checkouts endpoint response

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 34 Nick Clemens 2023-10-11 14:56:24 UTC
Created attachment 156832 [details] [review]
Bug 25393: Distinguish between auto or normal renewals in GetSoonestRenewDate

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 35 Nick Clemens 2023-10-11 14:56:27 UTC
Created attachment 156833 [details] [review]
Bug 25393: atomicupdate file

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 36 Nick Clemens 2023-10-11 14:56:30 UTC
Created attachment 156834 [details] [review]
Bug 25393: Auto renewals logic reimplementation:

Check if it's too soon for a manual renewal  even if 'Automatic renewals' is enabled
Allow for a manual renewal even if it's too soon for an automatic renewal

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 37 Nick Clemens 2023-10-11 14:56:33 UTC
Created attachment 156835 [details] [review]
Bug 25393: Update CanBookBeRenewed pod with bug 25758 changes

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 38 Nick Clemens 2023-10-11 14:56:36 UTC
Created attachment 156836 [details] [review]
Bug 25393: Tests - Variable renaming

issue_4 is an auto_renew issue, rename to auto_renew_issue

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 39 Nick Clemens 2023-10-11 14:56:39 UTC
Created attachment 156837 [details] [review]
Bug 25393: Update Circulation.t

prove t/db_dependent/Circulation.t

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 40 Nick Clemens 2023-10-11 14:56:42 UTC
Created attachment 156838 [details] [review]
Bug 25393: (QA follow-up) Report 'too_soon' errors from cron

This patchset made it possible for 'too_soon' to be returned instead of 'auto_too_soon' - we just need to take that into account in the error listing

To test:
1 - Set circ rule to no renewal before 2, no auto renewal before 3
2 - Checkout 3 items with auto renew, due tomorrow, in 2 days, in 3 days
3 - perl misc/cronjobs/automatic_renewals.pl -v
4 - Confirm 1 can be renewed, 1 is too soon, 1 is auto too soon

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 41 Nick Clemens 2023-10-11 14:56:45 UTC
Created attachment 156839 [details] [review]
Bug 25393: (QA follow-up) simplify auto_renew condition

_CanBookBeAutoRenewed will only ever return 'auto_too_soon' not 'too_soon' so we can do a simple equality check

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 42 Nick Clemens 2023-10-11 14:56:48 UTC
Created attachment 156840 [details] [review]
Bug 25393: (QA follow-up) Tidy

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 43 Nick Clemens 2023-10-11 14:57:05 UTC
Test plan:
C4/Circulation.pm:
if($auto_renew =~ 'too_soon'){
$auto_renew is return from _CanBookBeAutoRenewed - will never be 'too_soon'

Check messages on opac-user

1 - Checkout 3 items to a patron, set for auto renewal, make sure due dates are:
    Tomorrow
    2 days from now
    3 days from now
2 - Set 'norenewalbefore' rule for this patron's issues to be 2
3 - View patron in OPAC, renewal should be denied for all 3 items:
    Automatic renewal ( 5 of 5 renewals remaining )
4 - View patron in SCO, renewal should be denied for all 3 items:
    This item has been scheduled for automatic renewal and cannot be renewed
5 - View patron in staff interface, renewal should be denied for all 3 items
    Scheduled for automatic renewal(5 of 5 renewals remaining)
6 - Apply patch, updatedatabase, restart_all
7 - View circ rules, confirm new column 'no automatic renew before' with value equal to 'no renewal before'
8 - View patron in OPAC, 1 item can be renewed (due tomorrow), other 2 have updated message:
    Renew ( 5 of 5 renewals remaining ) This item is scheduled for auto renewal.
    No renewal before 10/11/2023 ( 5 of 5 renewals remaining ) This item is scheduled for auto renewal.
    No renewal before 10/12/2023 ( 5 of 5 renewals remaining ) This item is scheduled for auto renewal.
9 - View patron in SCO, 1 can be renewed, updated messages on others:
    This item cannot yet be renewed. <Check in item> This item is scheduled for automatic renewal
    This item cannot yet be renewed. <Check in item> This item is scheduled for automatic renewal
    <Renew item> This item is scheduled for automatic renewal
10 - View patron in staff interface, 1 item can be renewed, other 2 have updated message:
    No renewal before 10/12/2023(5 of 5 renewals remaining)
    No renewal before 10/11/2023(5 of 5 renewals remaining)
    <Checkbox>(5 of 5 renewals remaining)
11 - Update circ rule, set 'no renewal before' to 3
12 - Should now be able to renew items due tomorrow and 2 days ahead on all interfaces
13 - Update circ rule, set 'no renewal before' to 4
14 - Should now be able to renew all items on all interfaces
15 - Renew 1 item on each interface, confirm success
16 - Check in items, checkout as before
17 - Update circ rules, set 'no renewal before' to 1
18 - Items cannot be renewed on any interface
19 - perl misc/cronjobs/automatic_renewals.pl -v
     found 3 auto renewals
examining item '973' to auto renew
examining item '974' to auto renew
Issue id: 226 for borrower: 21 and item: 974 would not be renewed. (auto_too_soon)
examining item '975' to auto renew
Issue id: 227 for borrower: 21 and item: 975 would not be renewed. (auto_too_soon)
20 - Update circ rules, set 'no automatic renewal before' to 3
21 - perl misc/cronjobs/automatic_renewals.pl -v
     getting auto renewals
found 3 auto renewals
examining item '973' to auto renew
examining item '974' to auto renew
examining item '975' to auto renew
Issue id: 227 for borrower: 21 and item: 975 would not be renewed. (auto_too_soon)
22 - Update circ rules, set 'no automatic renewal before' to 4
23 - perl misc/cronjobs/automatic_renewals.pl -v
    getting auto renewals
found 3 auto renewals
examining item '973' to auto renew
examining item '974' to auto renew
examining item '975' to auto renew
24 - Update circ rules, set 'no automatic renewal before' to 3
25 - perl misc/cronjobs/automatic_renewals.pl -v -c
     examining item '973' to auto renew
examining item '974' to auto renew
examining item '975' to auto renew
Issue id: 230 for borrower: 21 and item: 975 will not be renewed. (auto_too_soon)
26 - Nothing is renewed, because 'no renewal before' is 1, too_soon for all 3
27 - Update circ rules, set 'no renewal before' to 2
28 - perl misc/cronjobs/automatic_renewals.pl -v -c
     getting auto renewals
found 3 auto renewals
examining item '973' to auto renew
Issue id: 228 for borrower: 21 and item: 973 will be renewed.
examining item '974' to auto renew
examining item '975' to auto renew
Issue id: 230 for borrower: 21 and item: 975 will not be renewed. (auto_too_soon)
29 - Confirm 1 issue was renewed
30 - Update circ rules, set 'no renewal before' to 3
31 - perl misc/cronjobs/automatic_renewals.pl -v -c
    getting auto renewals
found 3 auto renewals
examining item '973' to auto renew
Issue id: 228 for borrower: 21 and item: 973 will not be renewed. (auto_too_soon)
examining item '974' to auto renew
Issue id: 229 for borrower: 21 and item: 974 will be renewed.
examining item '975' to auto renew
Issue id: 230 for borrower: 21 and item: 975 will not be renewed. (auto_too_soon)
32 - Confirm a second issue was renewed
33 - Update circ rules, set both ...renew before to 4
34 - Confirm third issue was renewed
Comment 44 Tomás Cohen Arazi 2023-10-20 19:31:54 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 45 Fridolin Somers 2023-10-26 06:18:24 UTC
Enhancement not pushed to 23.05.x
Comment 46 Nick Clemens 2023-12-08 12:31:30 UTC
*** Bug 22018 has been marked as a duplicate of this bug. ***
Comment 47 Jonathan Druart 2024-01-11 08:05:00 UTC
*** Bug 35735 has been marked as a duplicate of this bug. ***