In the description for the AuthorityMergeLimit system preference, it says it is controlled by the misc/migration_tools/merge_authority.pl cronjob. However, merge_authority.pl is not in the migration_tools directory but in the cronjobs.
Created attachment 104443 [details] [review] Bug 25394: Cronjob path in the AuthorityMergeLimit syspref description is wrong
Created attachment 104444 [details] [review] Bug 25394: Cronjob path in the AuthorityMergeLimit syspref description is wrong Test plan: 1- Apply patch 2- Go to Administration > Global system preferences > Authorities 3- The path to merge_authorities.pl in the AuthorityMergeLimit description should now read misc/cronjobs/merge_authorities.pl
I hope I did this right. I seldom do patches and forget the process in between each time...
(In reply to Caroline Cyr La Rose from comment #3) > I hope I did this right. I seldom do patches and forget the process in > between each time... Looks like you remembered the process, as it works! 8-) However, the script name now shows in the system preference as 'merge_authority.pl', rather than 'merge_authorities.pl' 8-( The test plan is correct though. If you could fix that up, I'll sign it off. David
Created attachment 104457 [details] [review] Bug 25394: Cronjob path in the AuthorityMergeLimit syspref description is wrong Test plan: 1- Apply patch 2- Go to Administration > Global system preferences > Authorities 3- The path to merge_authorities.pl in the AuthorityMergeLimit description should now read misc/cronjobs/merge_authorities.pl
Hi David! Good thing you have eagle eyes! I have corrected the whole thing again (cronjobs + authorities)
Created attachment 104458 [details] [review] Bug 25394: Cronjob path in the AuthorityMergeLimit syspref description is wrong Test plan: 1- Apply patch 2- Go to Administration > Global system preferences > Authorities 3- The path to merge_authorities.pl in the AuthorityMergeLimit description should now read misc/cronjobs/merge_authorities.pl Signed-off-by: David Nind <david@davidnind.com>
(In reply to Caroline Cyr La Rose from comment #6) > Good thing you have eagle eyes! Only sometimes, today was your lucky day! 8-)
Created attachment 105300 [details] [review] Bug 25394: Cronjob path in the AuthorityMergeLimit syspref description is wrong Test plan: 1- Apply patch 2- Go to Administration > Global system preferences > Authorities 3- The path to merge_authorities.pl in the AuthorityMergeLimit description should now read misc/cronjobs/merge_authorities.pl Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 20.11, thanks to everybody involved!
backported to 20.05.x for 20.05.01
backported to 19.11.x for 19.11.07
Backported to 19.05.x branch for 19.05.13