In the staff interface cart the options for downloading have been moved into a menu button. In the OPAC cart the download button still pops up a separate window with download format options. The OPAC cart should be modified to match the staff interface, with an integrated menu button and no pop-up.
Created attachment 104717 [details] [review] Bug 25402: Put OPAC cart download options into dropdown menu This patch modifies the process of downloading a cart so that it doesn't involve a separate popup window. To test, apply the patch and add some titles to the cart in the OPAC. - Open the cart - The "Download" button should now be a dropdown menu. - Selecting any of the download options should trigger a download prompt. - Test with and without some CSV profiles which have been configured for use in the OPAC
Created attachment 105046 [details] [review] Bug 25402: Put OPAC cart download options into dropdown menu This patch modifies the process of downloading a cart so that it doesn't involve a separate popup window. To test, apply the patch and add some titles to the cart in the OPAC. - Open the cart - The "Download" button should now be a dropdown menu. - Selecting any of the download options should trigger a download prompt. - Test with and without some CSV profiles which have been configured for use in the OPAC Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This is great, I didn't like having a pop-up inside of a pop-up. Thanks Owen.
Should/could we not remove downloadBasket with this patch? Was wondering because I expected the pull down code to be removed elsewhere in the patch set.
Created attachment 106001 [details] [review] Bug 25402: (QA follow-up) Remove unused downloadBasket function This patch removes the now-unused downloadBasket function from basket.js. The patch should have no effect on the functionality of the download process.
Created attachment 106113 [details] [review] Bug 25402: Put OPAC cart download options into dropdown menu This patch modifies the process of downloading a cart so that it doesn't involve a separate popup window. To test, apply the patch and add some titles to the cart in the OPAC. - Open the cart - The "Download" button should now be a dropdown menu. - Selecting any of the download options should trigger a download prompt. - Test with and without some CSV profiles which have been configured for use in the OPAC Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 106114 [details] [review] Bug 25402: (QA follow-up) Remove unused downloadBasket function This patch removes the now-unused downloadBasket function from basket.js. The patch should have no effect on the functionality of the download process. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
It would be good to remove downloadBasket from koha-tmpl/intranet-tmpl/prog/js/basket.js as well, on its own bug report ofc.
Pushed to master for 20.11, thanks to everybody involved!
choosing to backport enhancement backported to 20.05.x for 20.05.02
enhancement, not backporting to 19.11.x