It has been suggested that it would be useful to add title attributes to the different numbers on the return claims tab in the checkouts and patron details pages. In addition, color coding them ( and removing the slash ) will make the numbers easier to read.
Created attachment 104608 [details] [review] Bug 25430: Improve the styling of the claims returned tab It has been suggested that it would be useful to add title attributes to the different numbers on the return claims tab in the checkouts and patron details pages. In addition, color coding them ( and removing the slash ) will make the numbers easier to read. Test Plan: 1) Set up return claims for your system 2) Apply this patch 3) View the claims tab for someone with not claims, and someone with claims 4) Note the resolved claims are green and have a "tooltip" when hovered over 5) Note the unresolved claims are green if 0, and yellow if not 0, and also have a "tooltip"
Created attachment 106211 [details] [review] Bug 25430: Improve the styling of the claims returned tab It has been suggested that it would be useful to add title attributes to the different numbers on the return claims tab in the checkouts and patron details pages. In addition, color coding them ( and removing the slash ) will make the numbers easier to read. Test Plan: 1) Set up return claims for your system 2) Apply this patch 3) View the claims tab for someone with not claims, and someone with claims 4) Note the resolved claims are green and have a "tooltip" when hovered over 5) Note the unresolved claims are green if 0, and yellow if not 0, and also have a "tooltip" Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Created attachment 108350 [details] [review] Bug 25430: Improve the styling of the claims returned tab It has been suggested that it would be useful to add title attributes to the different numbers on the return claims tab in the checkouts and patron details pages. In addition, color coding them ( and removing the slash ) will make the numbers easier to read. Test Plan: 1) Set up return claims for your system 2) Apply this patch 3) View the claims tab for someone with not claims, and someone with claims 4) Note the resolved claims are green and have a "tooltip" when hovered over 5) Note the unresolved claims are green if 0, and yellow if not 0, and also have a "tooltip" Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
I like that the added ids will also allow to hide the resolved claims making this stand out a little less when things are in order.
Those 2 green eyes are staring at me! https://snipboard.io/MwrGmt.jpg
(In reply to Jonathan Druart from comment #5) > Those 2 green eyes are staring at me! > https://snipboard.io/MwrGmt.jpg LOL!
(In reply to Jonathan Druart from comment #5) > Those 2 green eyes are staring at me! It wouldn't help with the staring, but I do think perhaps "label-default" would be more correct for the "0" state.
Created attachment 108521 [details] [review] Bug 25430: Use label-default for 0
Can I get an signoff on this follow-up?
Created attachment 108629 [details] [review] Bug 25430: Use label-default for 0 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master for 20.11, thanks to everybody involved!
enhancement will not be backported to 20.05.x
There is more work needed on this one, see 26561.