On very small screen size (608px or less) and viewing your cart (opac-basket.pl) the selections-toolbar is set to 'display: none'. If a user is using a device with a small screen they are unable to perform some actions like: -Select All -Clear All -Remove items -Add to list -Place hold
Created attachment 105353 [details] [review] Bug 25434: Display selections-toolbar on small screens
This patch will show: https://snipboard.io/M4HYg6.jpg Maybe we should remove the other selectors from this CSS rule as well.
I wasn't sure if we should turn those options into a dropdown like we do on the OPAC results page. https://snipboard.io/4xMOz8.jpg Or maybe that is for another patch?
I am not sure how these would look in a pull down. Jonathan's suggestion looks good at first clance. This is set to NEW still - something missing?
Created attachment 105477 [details] [review] Bug 25434: Display selections-toolbar on small screens Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 105740 [details] [review] Bug 25434: Display selections-toolbar on small screens Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 20.11, thanks to everybody involved!
backported to 20.05.x for 20.05.01
this patch doesn't seem to work on 19.11.x, the selections-toolbar still disappeared when i made the window smaller. not backported.
Aleshia, Did you regenerate the OPAC CSS?
I didn't know I needed to regenerate the OPAC CSS. Looks good in 19.11.x now. backported to 19.11.x for 19.11.08
Investigating backport to 19.05.x: I don't see a CSS regeneration commit in master, 20.05.x and 19.11.x What did I miss?
(In reply to Victor Grousset/tuxayo from comment #12) > Investigating backport to 19.05.x: > I don't see a CSS regeneration commit in master, 20.05.x and 19.11.x > What did I miss? I missed it, here and in other bug reports. We have a check in the QA tools but it does not seem to work (I will have a look). I have pushed a generic "Compiled CSS (OPAC)" (b4f3a0f0a6) commit to get back to a correct situation.
Can you please test the related merge request: https://gitlab.com/koha-community/qa-test-tools/-/issues/34
Ok, issue found and reported in the merge request: https://gitlab.com/koha-community/qa-test-tools/-/merge_requests/25