The framework files still in SQL need an update to reflect changes in the po files.
Created attachment 105308 [details] [review] Bug 25448: Update German (de-DE) framework files The updated files have been auto-generated based on the po files and downloaded from https://translate.koha-community.org/files/ To test: - Make sure German language is installed, see: https://wiki.koha-community.org/wiki/Installation_of_additional_languages_for_OPAC_and_INTRANET_staff_client - Run the web installer and choose de-DE - Select all sample files - Make sure they all install without any errors
-- Create the ACQ framework based on the default framework, fields 952 only -INSERT IGNORE INTO biblio_framework VALUES( 'ACQ', 'Erwerbung' ); +INSERT IGNORE INTO biblio_framework VALUES( 'ACQ', 'Acquisition framework' ); Is that correct?
Created attachment 109385 [details] [review] Bug 25448: Update German (de-DE) framework files The updated files have been auto-generated based on the po files and downloaded from https://translate.koha-community.org/files/ To test: - Make sure German language is installed, see: https://wiki.koha-community.org/wiki/Installation_of_additional_languages_for_OPAC_and_INTRANET_staff_client - Run the web installer and choose de-DE - Select all sample files - Make sure they all install without any errors
Hi Jonathan, thx for catching this! It looks like an issue with how the files are generated - the string is translated in pootle, but in the files it's not. I have changed this one line manually.
Created attachment 109437 [details] [review] Bug 25448: Update German (de-DE) framework files The updated files have been auto-generated based on the po files and downloaded from https://translate.koha-community.org/files/ To test: - Make sure German language is installed, see: https://wiki.koha-community.org/wiki/Installation_of_additional_languages_for_OPAC_and_INTRANET_staff_client - Run the web installer and choose de-DE - Select all sample files - Make sure they all install without any errors Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Trivial, skipping QA.
Pushed to master for 20.11, thanks to everybody involved!
enhancement will not be backported
(In reply to Lucas Gass from comment #8) > enhancement will not be backported Hi Lucas, can you please reconsider? This adds the missing fields and translations already present in the en frameworks in 20.05. It's a bit of a grey area with these installer fixes as I would not consider them a bug and it makes most sense to write them at the end of a release circle when things stop changing.
backported to 20.05.x for 20.05.04
backported to 19.11.x for 19.11.10
Not backported to oldoldstable (19.05.x). Feel free to ask if it's needed.