Replicated with Koha 19.11.04 and 19.11.05 Steps to reproduce: 1) Bring up the OPAC on a mobile device with a smaller screen (e.g. cell phone) or using an emulator 2) Log into an account 3) Find the button labeled "Your account menu" 4) Click it. 5) Nothing happens. ****** I didn't see any errors in the browser console or in the Koha logs. I tested this with 18.11.05 and clicking the button expands the menu as you'd expect.
Bisecting: 0 revisions left to test after this (roughly 0 steps) [fed5158d66abafbe482a3625fa010c160c82a529] Bug 18084: Language selector hidden in user menu on mobile interfaces
Created attachment 105302 [details] [review] Bug 25492: Your Account Menu button does nothing on mobile devices This patch removes some redundant code from the OPAC JavaScript which was causing problems with the show/hide action on two controls which are shown only at narrower browser widths: The "Your account" menu shown when the user is on a user-related page, and the "Refine your search" menu shown on the search results page. To test, apply the patch and go to the OPAC. Narrow your browser width to below 768 pixels. - Perform a search. - On the search results page you should see a "Refine your search" link at the top of the results. Clicking it should expand and collapse the facets menu. - Log in to the OPAC. - On the "Your summary" page there should be a "Your account menu" link at the top of the main part of the page. Clicking it should expand and collapse the account menu. - Verify that these menus display correctly when you widen and narrow the browser window.
Created attachment 105358 [details] [review] Bug 25492: Your Account Menu button does nothing on mobile devices This patch removes some redundant code from the OPAC JavaScript which was causing problems with the show/hide action on two controls which are shown only at narrower browser widths: The "Your account" menu shown when the user is on a user-related page, and the "Refine your search" menu shown on the search results page. To test, apply the patch and go to the OPAC. Narrow your browser width to below 768 pixels. - Perform a search. - On the search results page you should see a "Refine your search" link at the top of the results. Clicking it should expand and collapse the facets menu. - Log in to the OPAC. - On the "Your summary" page there should be a "Your account menu" link at the top of the main part of the page. Clicking it should expand and collapse the account menu. - Verify that these menus display correctly when you widen and narrow the browser window. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 105427 [details] [review] Bug 25492: Your Account Menu button does nothing on mobile devices This patch removes some redundant code from the OPAC JavaScript which was causing problems with the show/hide action on two controls which are shown only at narrower browser widths: The "Your account" menu shown when the user is on a user-related page, and the "Refine your search" menu shown on the search results page. To test, apply the patch and go to the OPAC. Narrow your browser width to below 768 pixels. - Perform a search. - On the search results page you should see a "Refine your search" link at the top of the results. Clicking it should expand and collapse the facets menu. - Log in to the OPAC. - On the "Your summary" page there should be a "Your account menu" link at the top of the main part of the page. Clicking it should expand and collapse the account menu. - Verify that these menus display correctly when you widen and narrow the browser window. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 20.11, thanks to everybody involved!
backported to 20.05.x for 20.05.01
backported to 19.11.x for 19.11.07
Backported to 19.05.x branch for 19.05.12
*** Bug 25830 has been marked as a duplicate of this bug. ***
*** Bug 25831 has been marked as a duplicate of this bug. ***