We have a dependency on libjs-jquery for the Debian packages, but it appears to be unused.
Created attachment 104911 [details] [review] Bug 25509: Remove useless libjs-jquery dependency We don't use the libjs-jquery package, so we should remove the dependency. To Test: 1) Build package (out of scope of test plan) 2) Install package 3) Note that libjs-jquery is marked by apt as no longer required 4) Remove libjs-jquery package from system and note how it doesn't take koha-common with it
Looking back at 97232eee15e, the original "koha" package by Lars had "libjs-jquery", "tinymce2", and "libjs-yui". You can see there that he was overriding the bundled jquery, tinymce, and yui with the Debian package versions. But we don't do that anymore.
Created attachment 105951 [details] [review] Bug 25509: Remove useless libjs-jquery dependency We don't use the libjs-jquery package, so we should remove the dependency. To Test: 1) Build package (out of scope of test plan) 2) Install package 3) Note that libjs-jquery is marked by apt as no longer required 4) Remove libjs-jquery package from system and note how it doesn't take koha-common with it Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Yahoo. Cheers, Jonathan!
Created attachment 106075 [details] [review] Bug 25509: Remove useless libjs-jquery dependency We don't use the libjs-jquery package, so we should remove the dependency. To Test: 1) Build package (out of scope of test plan) 2) Install package 3) Note that libjs-jquery is marked by apt as no longer required 4) Remove libjs-jquery package from system and note how it doesn't take koha-common with it Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Nice spot.. Passing QA
Pushed to master for 20.11, thanks to everybody involved!
backported to 20.05.x for 20.05.02
backported to 19.11.x for 19.11.08
Backported to 19.05.x branch for 19.05.14