Bug 2553 - alphabetize dropdown menus
Summary: alphabetize dropdown menus
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: 3.8
Hardware: All All
: P3 minor with 5 votes (vote)
Assignee: Galen Charlton
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-25 10:24 UTC by Chris Cormack
Modified: 2013-12-05 19:59 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Alphabetization in Koha (716.00 KB, application/msword)
2009-05-27 18:38 UTC, Chris Cormack
Details
Patch for Most-Circulated Items (2.90 KB, patch)
2009-07-16 20:45 UTC, Chris Cormack
Details | Diff | Splinter Review
Patch for drop-downs in Existing Requests (964 bytes, patch)
2009-07-16 21:46 UTC, Chris Cormack
Details | Diff | Splinter Review
Patch for location drop-down in Catalog Statistics Wizard (941 bytes, patch)
2009-07-17 23:02 UTC, Chris Cormack
Details | Diff | Splinter Review
Patch for drop-down lists in Circulation Statistics Wizard (1.47 KB, patch)
2009-07-17 23:25 UTC, Chris Cormack
Details | Diff | Splinter Review
Patch for flocation drop-down in Serials Statistic Wizard. (1.17 KB, patch)
2009-07-18 00:19 UTC, Chris Cormack
Details | Diff | Splinter Review
Patch for drop-downs in Acquisitions pages (2.95 KB, patch)
2009-07-18 00:22 UTC, Chris Cormack
Details | Diff | Splinter Review
Additional patch for the Serials statistics form using GetBranchesLoop (3.09 KB, patch)
2009-07-22 01:11 UTC, Chris Cormack
Details | Diff | Splinter Review
Additional patch for the Catalog Statistics form using GetBranchesLoop (2.68 KB, patch)
2009-07-22 01:12 UTC, Chris Cormack
Details | Diff | Splinter Review
Additional patch for the Checkout Statistics form using GetBranchesLoop (2.71 KB, patch)
2009-07-22 01:13 UTC, Chris Cormack
Details | Diff | Splinter Review
Additional patch for drop-down in Existing Requests. (3.09 KB, patch)
2009-07-23 01:13 UTC, Chris Cormack
Details | Diff | Splinter Review
Proposed patch for opac-topissues.pl (1.67 KB, patch)
2009-08-02 02:43 UTC, Chris Cormack
Details | Diff | Splinter Review
Proposed patch for itemslost.pl (3.66 KB, patch)
2009-08-14 20:10 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 2553 [Serials report] alphabetize dropdown menus (3.21 KB, patch)
2012-08-23 14:13 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 2553 [Serials report] alphabetize dropdown menus (3.24 KB, patch)
2012-08-23 14:17 UTC, Nicole C. Engard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 00:52:30 UTC


---- Reported by emily.funk@liblime.com 2008-08-25 10:24:46 ----

Enhancement request to: Alphabetize the dropdown menus in Koha. (Specifically the ones containing Libraries.)



---- Additional Comments From jransom@library.org.nz 2009-01-26 14:46:00 ----

It appears that some alphabetized sorting is being done.

In add order in acqusitions the item type box appears random. EG:

1.Adult Fiction
2.Adult Nonfiction - Horowhenua
3.Junior  Fiction - Castle
4.Junior Fiction
5.Junior Fiction - Kermit
6.Largeprint Fiction
7.Largeprint Nonfiction
8.Adult Nonfiction - Maori
9.Adult Nonfiction.

I would have expected  them to appear in this order: 1,9,2,8,4,3,5,6,7.

But if I look at the item type codes for those then they are in perfect order:
1. BF
2. BH
3. BJC
4. BJF
5. BJK
6. BLF
7. BLN
8. BM
9. BN

The confusion comes in, in this instance, because they are sorted by code but display by description.

2 options therefore:

1. sort by description and display by description (as at present)
or
2. Sort by code (as at present) and display the code (optionally and preferably followed by the plain english description.)

eg:
1. BF - Adult Fiction
2. BH - Adult Nonfiction - Horowhenua
3. BJC - Junior  Fiction - Castle
4. BJF - Junior Fiction
5. BJK - Junior Fiction - Kermit 

My personal preference would be to sort by description, but equally it could be setup preference as to whether to sort by code or description.



---- Additional Comments From smoreland@nekls.org 2009-05-27 18:38:38 ----

Created an attachment
Alphabetization in Koha

Attached is a document (created a few updates ago) listing various parts of the catalog that could be alphabetized, such as the collection codes on the advanced search pages and all drop down menu's.  

This also includes examples of 'wish list' functionality, such as having drop down menus that show branchcode default to the SET library.  This would make copy cataloging in a multi-branch/multi-library installation more efficient.

The attachment includes examples from both the OPAC and Staff Client.

As a librarian, I can say that we really do feel uneasy when we see things out of alphabetical order...it's part of our genetic make up. ;-)



---- Additional Comments From gcollum@gmail.com 2009-07-16 20:45:20 ----

Created an attachment
Patch for Most-Circulated Items





---- Additional Comments From gcollum@gmail.com 2009-07-16 21:46:13 ----

Created an attachment
Patch for drop-downs in Existing Requests





---- Additional Comments From gcollum@gmail.com 2009-07-17 23:02:00 ----

Created an attachment
Patch for location drop-down in Catalog Statistics Wizard





---- Additional Comments From gcollum@gmail.com 2009-07-17 23:25:30 ----

Created an attachment
Patch for drop-down lists in Circulation Statistics Wizard





---- Additional Comments From gcollum@gmail.com 2009-07-18 00:19:58 ----

Created an attachment
Patch for flocation drop-down in Serials Statistic Wizard.





---- Additional Comments From gcollum@gmail.com 2009-07-18 00:22:44 ----

Created an attachment
Patch for drop-downs in Acquisitions pages

The patch for the Acquisitions pages takes care of Joann's original bug entry.  The previous patches take care of some of the references in the attached Doc file.



---- Additional Comments From gcollum@gmail.com 2009-07-19 00:00:17 ----

The attached Doc makes mention of Collection Codes not being sorted in Advanced Search.  I opened up another bug report, 3428, since this was not related to drop-downs, and submitted a patch.



---- Additional Comments From gmcharlt@gmail.com 2009-07-21 01:23:01 ----

Pushed the six patches submitted to date to HEAD.  As Jesse suggested, it would be better to use GetBranchesLoop.



---- Additional Comments From gcollum@gmail.com 2009-07-22 01:11:51 ----

Created an attachment
Additional patch for the Serials statistics form using GetBranchesLoop





---- Additional Comments From gcollum@gmail.com 2009-07-22 01:12:46 ----

Created an attachment
Additional patch for the Catalog Statistics form using GetBranchesLoop





---- Additional Comments From gcollum@gmail.com 2009-07-22 01:13:49 ----

Created an attachment
Additional patch for the Checkout Statistics form using GetBranchesLoop





---- Additional Comments From gcollum@gmail.com 2009-07-23 01:13:02 ----

Created an attachment
Additional patch for drop-down in Existing Requests.

Uses GetBranchesLoop to populate the drop-down lists in Existing Holds.



---- Additional Comments From gcollum@gmail.com 2009-08-02 02:43:46 ----

Created an attachment
Proposed patch for opac-topissues.pl





---- Additional Comments From smoreland@nekls.org 2009-08-04 16:30:16 ----

Garry, this is probably not an appropriate use of bugzilla, but THANK YOU!  I am excited to get at these patches when our vendor next updates our installation.




---- Additional Comments From gcollum@gmail.com 2009-08-14 20:10:23 ----

Created an attachment
Proposed patch for itemslost.pl





--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 00:52 UTC  ---

This bug was previously known as _bug_ 2553 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2553
Imported an attachment (id=721)
Imported an attachment (id=722)
Imported an attachment (id=723)
Imported an attachment (id=724)
Imported an attachment (id=725)
Imported an attachment (id=726)
Imported an attachment (id=727)
Imported an attachment (id=728)
Imported an attachment (id=729)
Imported an attachment (id=730)
Imported an attachment (id=731)
Imported an attachment (id=732)
Imported an attachment (id=733)

Actual time not defined. Setting to 0.0
The original reporter of this bug does not have
   an account here. Reassigning to the person who moved
   it here: chris@bigballofwax.co.nz.
   Previous reporter was emily.funk@liblime.com.
The original submitter of attachment 721 [details] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 722 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 723 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 724 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 725 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 726 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 727 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 728 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 729 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 730 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 731 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 732 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 733 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.

Comment 1 Katrin Fischer 2011-04-25 14:03:31 UTC
Was all of this pushed? 
I suggest closing the bug if that's the case.
Comment 2 Owen Leonard 2012-08-23 14:13:27 UTC Comment hidden (obsolete)
Comment 3 Nicole C. Engard 2012-08-23 14:17:30 UTC
Created attachment 11789 [details] [review]
[SIGNED-OFF] Bug 2553 [Serials report] alphabetize dropdown menus

Rebase of a patch originally submitted by gcollum@gmail.com
Original commit message:

Improvement on the previous patch through the use of GetBranchesLoop.
Added code so that the logged in location will be the location that
is selected by default.

Fixed a couple of minor xhtml errors.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Comment 4 Jonathan Druart 2012-08-27 12:40:33 UTC
QA Comment:
Works as expected. Nothing to say.
Marked as Passed QA.
Comment 5 Paul Poulain 2012-09-04 16:29:50 UTC
Patch pushed to master. More a small bugfix than an ENH imo
Comment 6 Chris Cormack 2012-09-05 10:14:35 UTC
Pushed to 3.8.x, will be in 3.8.5