At branchtransfers.pl, one selects a destination branch and scans in any number of items to generate transfers to that branch. However, anything that makes the page reload causes your branch selection to be lost, reverting you back to whichever branch comes first alphabetically. To test: - Have an item waiting for hold pickup at Branch A - go to Circulation > Transfers, attempt to transfer your waiting item to branch C - Get error about the hold - get routed back to Transfers, but branch selector now shows Branch B This is an invitation to error when one has a stack of books to send all to the same branch. Could that error handling get moved into a modal or something that won't reload the page?
Created attachment 105224 [details] [review] Bug 25537: Page reload at branchtransfers.pl loses destination branch At branchtransfers.pl, one selects a destination branch and scans in any number of items to generate transfers to that branch. However, anything that makes the page reload causes your branch selection to be lost, reverting you back to whichever branch comes first alphabetically. This is an invitation to error when one has a stack of books to send all to the same branch. Could that error handling get moved into a modal or something that won't reload the page? Test Plan: 1) Place a hold on an item and set it to waiting 2) Initiate a branch transfer from branchtransfers.pl for any branch but the first in the pulldown branch selector 3) Choose to cancel the hold and transfer 4) Note the pulldown reverts to the first option 5) Apply this patch 6) Repeat steps 1-3 7) Note the pulldown retains your preveiously selected branch!
Created attachment 105476 [details] [review] Bug 25537: Page reload at branchtransfers.pl loses destination branch At branchtransfers.pl, one selects a destination branch and scans in any number of items to generate transfers to that branch. However, anything that makes the page reload causes your branch selection to be lost, reverting you back to whichever branch comes first alphabetically. This is an invitation to error when one has a stack of books to send all to the same branch. Could that error handling get moved into a modal or something that won't reload the page? Test Plan: 1) Place a hold on an item and set it to waiting 2) Initiate a branch transfer from branchtransfers.pl for any branch but the first in the pulldown branch selector 3) Choose to cancel the hold and transfer 4) Note the pulldown reverts to the first option 5) Apply this patch 6) Repeat steps 1-3 7) Note the pulldown retains your preveiously selected branch! Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Created attachment 105632 [details] [review] Bug 25537: Page reload at branchtransfers.pl loses destination branch At branchtransfers.pl, one selects a destination branch and scans in any number of items to generate transfers to that branch. However, anything that makes the page reload causes your branch selection to be lost, reverting you back to whichever branch comes first alphabetically. This is an invitation to error when one has a stack of books to send all to the same branch. Could that error handling get moved into a modal or something that won't reload the page? Test Plan: 1) Place a hold on an item and set it to waiting 2) Initiate a branch transfer from branchtransfers.pl for any branch but the first in the pulldown branch selector 3) Choose to cancel the hold and transfer 4) Note the pulldown reverts to the first option 5) Apply this patch 6) Repeat steps 1-3 7) Note the pulldown retains your preveiously selected branch! Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Simple and clear patch, no missing filters etc.. Passing QA
Pushed to master for 20.11, thanks to everybody involved!
backported to 20.05.x. for 20.05.01
backported to 19.11.x for 19.11.07
Backported to 19.05.x branch for 19.05.13