Master_DO #874 11:37:04 koha_1 | # Failed test 'ReservesControlBranch: ItemHomeLibrary, biblio1, patron1 should return 6 but returns 7' 11:37:04 koha_1 | # at t/db_dependent/Koha/Biblio.t line 408. 11:37:04 koha_1 | 11:37:04 koha_1 | # Failed test 'ReservesControlBranch: PatronLibrary, biblio1, patron1 should return 6 but returns 7' 11:37:04 koha_1 | # at t/db_dependent/Koha/Biblio.t line 408. 11:37:05 koha_1 | # Looks like you planned 29 tests but ran 31. 11:37:05 koha_1 | # Looks like you failed 2 tests of 31 run. 11:37:05 koha_1 | 11:37:05 koha_1 | # Failed test 'pickup_locations' 11:37:05 koha_1 | # at t/db_dependent/Koha/Biblio.t line 435. 11:37:06 koha_1 | # Looks like you failed 1 test of 12. 11:37:06 koha_1 | [09:37:06] t/db_dependent/Koha/Biblio.t Was failing earlier on D10 as well.
Created attachment 105093 [details] [review] Bug 25540: Use build_sample_item
Created attachment 105094 [details] [review] Bug 25540: DO NOT PUSH - diag statement
I have no idea what's going in here. There is a library that is picked from... somewhere? See second patch. Run the tests several times and it will fail at some point (before 30th run usually)
Again, Master_U18 #796
IMO This needs to be addressed for 20.05
Related test in t/db_dependent/Template/Plugin/Branches.t is failing as well: 14:31:13 koha_1 | # Failed test 'Libraries count is correct' 14:31:13 koha_1 | # at t/db_dependent/Template/Plugin/Branches.t line 176. 14:31:13 koha_1 | # got: '4' 14:31:13 koha_1 | # expected: '3' 14:31:13 koha_1 | 14:31:13 koha_1 | # Failed test 'Libraries count is correct' 14:31:13 koha_1 | # at t/db_dependent/Template/Plugin/Branches.t line 184. 14:31:13 koha_1 | # got: '4' 14:31:13 koha_1 | # expected: '3' 14:31:13 koha_1 | # Looks like you failed 2 tests of 4. 14:31:13 koha_1 | 14:31:13 koha_1 | # Failed test 'selected tests' 14:31:13 koha_1 | # at t/db_dependent/Template/Plugin/Branches.t line 189. 14:31:13 koha_1 | # Looks like you failed 1 test of 8. 14:31:13 koha_1 | 14:31:13 koha_1 | # Failed test 'pickup_locations() tests' 14:31:13 koha_1 | # at t/db_dependent/Template/Plugin/Branches.t line 192.
Created attachment 105266 [details] [review] Bug 25540: Default for branches.pickup_location must be 0 This is a try to fix failures in both t/db_dependent/Template/Plugin/Branches.t t/db_dependent/Koha/Biblio.t
Created attachment 105290 [details] [review] Bug 25540: Use build_sample_item Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 105291 [details] [review] Bug 25540: DO NOT PUSH - diag statement Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 105292 [details] [review] Bug 25540: Default for branches.pickup_location must be 0 This is a try to fix failures in both t/db_dependent/Template/Plugin/Branches.t t/db_dependent/Koha/Biblio.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Tha changes 'make sense'. But the Biblio.t tests explicitly delete all libraries and the added ones are totally controlled in terms of the pickup_location flag. I certainly reproduced the failure in t/db_dependent/Template/Plugin/Branches.t with a loop calling the test 30 times, and couldn't reproduce it after applying the patches.
Thanks guys.. Passing QA on this one too, changes make sense and tests now pass consistently for me.
Created attachment 105296 [details] [review] Bug 25540: Use build_sample_item Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 105297 [details] [review] Bug 25540: Default for branches.pickup_location must be 0 This is a try to fix failures in both t/db_dependent/Template/Plugin/Branches.t t/db_dependent/Koha/Biblio.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Nice work everyone! Pushed to master for 20.05
tests not failing on 19.11.x so not backporting
Still failing https://jenkins.koha-community.org/job/Koha_Master_U18/954/consoleFull https://jenkins.koha-community.org/job/Koha_Master_U16/134/consoleFull
(In reply to Jonathan Druart from comment #17) > Still failing > > https://jenkins.koha-community.org/job/Koha_Master_U18/954/consoleFull > https://jenkins.koha-community.org/job/Koha_Master_U16/134/consoleFull See bug 27062.
Created attachment 115204 [details] [review] Bug 25540: (follow-up) Test defined not true To test: prove -v t/db_dependent/Koha/Biblio.t it succeeds (maybe) add a library that is not a pickup_location prove the test it fails apply the patch prove! it passes!
Created attachment 115205 [details] [review] Bug 22284: (QA follow-up) Fix test failures Only libraries that are a pickup location will be returned as a pickup location To test: prove -v t/db_dependent/Koha/Biblio.t it succeeds (maybe) add a library that is not a pickup_location prove the test it fails apply the patch prove! it passes!
Follow up pushed to 20.05.x for 20.05.08