The Holds Queue table sorts name by firstname which is less helpful than sorting by surname
Created attachment 105159 [details] [review] Bug 25555: Invert patron name in holdsqueue.tt TEST PLAN: 1. Have multiple holds from multiple patrons and run the holds queue cron to populate the holds queue list. 2. Try sorting by patron and see that is sorts based on first name. 3. Apply patch 4. Try sorting again and now it should sort by surname.
Created attachment 105447 [details] [review] Bug 25555: Invert patron name in holdsqueue.tt TEST PLAN: 1. Have multiple holds from multiple patrons and run the holds queue cron to populate the holds queue list. 2. Try sorting by patron and see that is sorts based on first name. 3. Apply patch 4. Try sorting again and now it should sort by surname. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
It works! :D
Created attachment 105857 [details] [review] Bug 25555: Invert patron name in holdsqueue.tt TEST PLAN: 1. Have multiple holds from multiple patrons and run the holds queue cron to populate the holds queue list. 2. Try sorting by patron and see that is sorts based on first name. 3. Apply patch 4. Try sorting again and now it should sort by surname. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 20.11, thanks to everybody involved!
backported to 20.05.x for 20.05.01
enhancement, not backporting to 19.11.x
For the sake of release notes, I'm classifying this as a bug rather than an enhancement. Feel free to change it back if you think this is wrong.