We should follow the existing pattern and only show the problem reports entry on the dashboard, when there are pending problem reports: OPAC problem reports pending: 0
Created attachment 105482 [details] [review] Bug 25582: Don't show OPAC problems entry on dashboard when there are no reports This patch makes a minor correction to the template to correct the check on outstanding OPAC problem reports. An error was preventing the check from working correctly. To test, apply the patch and enable the OPACReportProblem system preference. - On the staff interface home page, check the area showing pending operations (suggestions, tags, etc.). - If you have no pending OPAC problem reports there should be no line for OPAC problem reports. - If necessary, mark all pending OPAC problem reports closed and confirm that when there are no outstanding reports the link is hidden. - If necessary, test that the link appears when you have one or more OPAC problem reports. - Go to the OPAC and use the "Report a problem" to submit a test report. - Check that the staff interface home page reflects that there is now a pending report.
Created attachment 105661 [details] Bug 25582 - Screenshot of border displaying on staff interface This works, but it leaves a border across the screen - see screen shot (this is after the patch is applied and there are no problem reports.
Created attachment 105668 [details] [review] Bug 25582: Don't show OPAC problems entry on dashboard when there are no reports This patch makes a minor correction to the template to correct the check on outstanding OPAC problem reports. An error was preventing the check from working correctly. To test, apply the patch and enable the OPACReportProblem system preference. - On the staff interface home page, check the area showing pending operations (suggestions, tags, etc.). - If you have no pending OPAC problem reports there should be no line for OPAC problem reports. - If necessary, mark all pending OPAC problem reports closed and confirm that when there are no outstanding reports the link is hidden. - Also test when there are no other outstanding reports in that section (suggestions, tags, patron modifications), nothing appears at all, not even the surrounding border. - If necessary, test that the link appears when you have one or more OPAC problem reports. - Go to the OPAC and use the "Report a problem" to submit a test report. - Check that the staff interface home page reflects that there is now a pending report.
Created attachment 105669 [details] [review] Bug 25582: Don't show OPAC problems entry on dashboard when there are no reports This patch makes a minor correction to the template to correct the check on outstanding OPAC problem reports. An error was preventing the check from working correctly. To test, apply the patch and enable the OPACReportProblem system preference. - On the staff interface home page, check the area showing pending operations (suggestions, tags, etc.). - If you have no pending OPAC problem reports there should be no line for OPAC problem reports. - If necessary, mark all pending OPAC problem reports closed and confirm that when there are no outstanding reports the link is hidden. - Also test when there are no other outstanding reports in that section (suggestions, tags, patron modifications), nothing appears at all, not even the surrounding border. - If necessary, test that the link appears when you have one or more OPAC problem reports. - Go to the OPAC and use the "Report a problem" to submit a test report. - Check that the staff interface home page reflects that there is now a pending report.
Created attachment 105673 [details] [review] Bug 25582: Don't show OPAC problems entry on dashboard when there are no reports This patch makes a minor correction to the template to correct the check on outstanding OPAC problem reports. An error was preventing the check from working correctly. To test, apply the patch and enable the OPACReportProblem system preference. - On the staff interface home page, check the area showing pending operations (suggestions, tags, etc.). - If you have no pending OPAC problem reports there should be no line for OPAC problem reports. - If necessary, mark all pending OPAC problem reports closed and confirm that when there are no outstanding reports the link is hidden. - Also test when there are no other outstanding reports in that section (suggestions, tags, patron modifications), nothing appears at all, not even the surrounding border. - If necessary, test that the link appears when you have one or more OPAC problem reports. - Go to the OPAC and use the "Report a problem" to submit a test report. - Check that the staff interface home page reflects that there is now a pending report. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 105739 [details] [review] Bug 25582: Don't show OPAC problems entry on dashboard when there are no reports This patch makes a minor correction to the template to correct the check on outstanding OPAC problem reports. An error was preventing the check from working correctly. To test, apply the patch and enable the OPACReportProblem system preference. - On the staff interface home page, check the area showing pending operations (suggestions, tags, etc.). - If you have no pending OPAC problem reports there should be no line for OPAC problem reports. - If necessary, mark all pending OPAC problem reports closed and confirm that when there are no outstanding reports the link is hidden. - Also test when there are no other outstanding reports in that section (suggestions, tags, patron modifications), nothing appears at all, not even the surrounding border. - If necessary, test that the link appears when you have one or more OPAC problem reports. - Go to the OPAC and use the "Report a problem" to submit a test report. - Check that the staff interface home page reflects that there is now a pending report. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 20.11, thanks to everybody involved!
backported to 20.05.x for 20.05.01
missing dependencies, not backported to 19.11.x