When adding a 'claims returend' from the checkouts table, the button disappears, but the date of the claim will only appear after a reload of the page. I think it would be more helpful to see the date right away as this helps to confirm the process worked correctly.
*** Bug 25734 has been marked as a duplicate of this bug. ***
Created attachment 109247 [details] [review] Bug 25584: Refresh checkouts table when a return claim is added This patch triggers a checkouts table refresh when a return claim is added. I also noticed the same when a return claim is deleted so it is now also refreshed. To test: 1. Set the ClaimReturnedLostValue to some valid value (2) 2. Check something out for a patron, and choose to display all checkouts => SUCCES: There's the checkouts table, showing the checkout 3. Click on the 'Claim returned' button and confirm => SUCCESS: There's no 'Claim returned' button anymore => ERROR: The checkout row doesn't display anything about the claim 4. Go to the 'Claims' tab, delete resolve and delete the claim 5. Go to the Checkouts tab => ERROR: It doesn't reflect the changes either 6. Apply this patch and start over => SUCCESS: Once the claim returned is added, the checkouts table is refreshed and the information updated => SUCCESS: On the Claims tab, if you delete the claim and go to the Checkouts tab, you are presented the button again. 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 109248 [details] [review] Bug 25584: Fix minor styling issue This patch makes the button present some space between the icon and the text. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 109352 [details] [review] Bug 25584: Refresh checkouts table when a return claim is added This patch triggers a checkouts table refresh when a return claim is added. I also noticed the same when a return claim is deleted so it is now also refreshed. To test: 1. Set the ClaimReturnedLostValue to some valid value (2) 2. Check something out for a patron, and choose to display all checkouts => SUCCES: There's the checkouts table, showing the checkout 3. Click on the 'Claim returned' button and confirm => SUCCESS: There's no 'Claim returned' button anymore => ERROR: The checkout row doesn't display anything about the claim 4. Go to the 'Claims' tab, delete resolve and delete the claim 5. Go to the Checkouts tab => ERROR: It doesn't reflect the changes either 6. Apply this patch and start over => SUCCESS: Once the claim returned is added, the checkouts table is refreshed and the information updated => SUCCESS: On the Claims tab, if you delete the claim and go to the Checkouts tab, you are presented the button again. 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com>
Created attachment 109353 [details] [review] Bug 25584: Fix minor styling issue This patch makes the button present some space between the icon and the text. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com>
Created attachment 109379 [details] [review] Bug 25584: Refresh checkouts table when a return claim is added This patch triggers a checkouts table refresh when a return claim is added. I also noticed the same when a return claim is deleted so it is now also refreshed. To test: 1. Set the ClaimReturnedLostValue to some valid value (2) 2. Check something out for a patron, and choose to display all checkouts => SUCCES: There's the checkouts table, showing the checkout 3. Click on the 'Claim returned' button and confirm => SUCCESS: There's no 'Claim returned' button anymore => ERROR: The checkout row doesn't display anything about the claim 4. Go to the 'Claims' tab, delete resolve and delete the claim 5. Go to the Checkouts tab => ERROR: It doesn't reflect the changes either 6. Apply this patch and start over => SUCCESS: Once the claim returned is added, the checkouts table is refreshed and the information updated => SUCCESS: On the Claims tab, if you delete the claim and go to the Checkouts tab, you are presented the button again. 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 109380 [details] [review] Bug 25584: Fix minor styling issue This patch makes the button present some space between the icon and the text. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 20.11, thanks to everybody involved!
backported to 20.05.x for 20.05.04
backported to 19.11.x for 19.11.10
Not backported to oldoldstable (19.05.x). Feel free to ask if it's needed.