In some cases there might be a refund to the account to balance and overpayment. The description created is "Overpayment refund". This string appears in the accounts table in the patron account and is currently not translatable. Added by commit 11c4cd73e19586ea74a7ac5ba7c88989dd8c4f21 Bug 21727: Add handling for cases requireing patron refunds
*** Bug 25833 has been marked as a duplicate of this bug. ***
Created attachment 109794 [details] [review] Bug 25596: Identify overpayment refunds for translation This patch ensure we can uniquely identify automatic overpayment refund credits from the accountlines by introducing a new account credit type and adding appropriate translations for the new code.
Created attachment 109818 [details] [review] Bug 25596: Identify overpayment refunds for translation This patch ensure we can uniquely identify automatic overpayment refund credits from the accountlines by introducing a new account credit type and adding appropriate translations for the new code.
Created attachment 110551 [details] [review] Bug 25596: Identify overpayment refunds for translation This patch ensure we can uniquely identify automatic overpayment refund credits from the accountlines by introducing a new account credit type and adding appropriate translations for the new code.
Test plan 1/ You'll need an overpayment refund to start... 1a/ Issue yourself and item and set the issue date early enough to create an overdue fine for at least 2 days worth of overdue fines 1b/ Run the overdues script to add the fines 1c/ As a patron, pay off the accruing fine 1d/ Return the item ensuring you backdate it at least a day 1e/ Check that there is an 'Overpayment refund' credit on the patrons account. 2/ Check that the overpayment string is translatable (i.e. it appears in the accounts include file)
Tried to test this, but I can't apply the patch
Created attachment 111940 [details] [review] Bug 25596: Identify overpayment refunds for translation This patch ensure we can uniquely identify automatic overpayment refund credits from the accountlines by introducing a new account credit type and adding appropriate translations for the new code. Test plan 1/ You'll need an overpayment refund to start... 1a/ Issue yourself and item and set the date due early enough to create an overdue fine for at least 2 days worth of overdue fines 1b/ Run the fines.pl script to add the fines 1c/ As a patron, pay off the accruing fine 1d/ Return the item ensuring you backdate it at least a day 1e/ Check that there is an 'Overpayment refund' credit on the patrons account. 2/ Check that the overpayment string is translatable (i.e. it appears in the accounts include file) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
I've rebased and tested - wouldn't mind another sign-off :)
The string is added to the .po file. However, when I have the patch on, and I try to backdate check in an item, it gives me a broken FK constraint... 1) Checkout an item to a patron with due date 2020/10/15 2) Run fines.pl 3) Pay fine 4) Checkin with backdate 2020/10/14 With patch, it gives me a software error; without patch, it works...
Created attachment 111992 [details] [review] Bug 25596: Identify overpayment refunds for translation This patch ensures we can uniquely identify automatic overpayment refund credits from the accountlines by introducing a new account credit type and adding appropriate translations for the new code. Test plan 1/ You'll need an overpayment refund to start... 1a/ Issue yourself and item and set the date due early enough to create an overdue fine for at least 2 days worth of overdue fines 1b/ Run the fines.pl script to add the fines 1c/ As a patron, pay off the accruing fine 1d/ Return the item ensuring you backdate it at least a day 1e/ Check that there is an 'Overpayment refund' credit on the patrons account. 2/ Check that the overpayment string is translatable (i.e. it appears in the accounts include file) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Hmm, I'm struggling to replicate your error Caroline.. did you run the included database update?
(In reply to Martin Renvoize from comment #11) > Hmm, I'm struggling to replicate your error Caroline.. did you run the > included database update? No, sorry. David Cook pointed this out to me. I was not able to come back and test since then (kohacon talks were too interesting!)
(In reply to Martin Renvoize from comment #11) > Hmm, I'm struggling to replicate your error Caroline.. did you run the > included database update? In my defense, it was not in the test plan, hehe :P
Created attachment 112078 [details] [review] Bug 25596: Identify overpayment refunds for translation This patch ensures we can uniquely identify automatic overpayment refund credits from the accountlines by introducing a new account credit type and adding appropriate translations for the new code. Test plan 1/ You'll need an overpayment refund to start... 1a/ Issue yourself and item and set the date due early enough to create an overdue fine for at least 2 days worth of overdue fines 1b/ Run the fines.pl script to add the fines 1c/ As a patron, pay off the accruing fine 1d/ Return the item ensuring you backdate it at least a day 1e/ Check that there is an 'Overpayment refund' credit on the patrons account. 2/ Check that the overpayment string is translatable (i.e. it appears in the accounts include file) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Pushed to master for 20.11, thanks to everybody involved!
does not apply cleanly to 20.05.x, no backport
Could you reconsider if this was rebased? Translation fixes can't be easily backported locally, especially since we support so many libraries with different languages.
(In reply to Katrin Fischer from comment #17) > Could you reconsider if this was rebased? > > Translation fixes can't be easily backported locally, especially since we > support so many libraries with different languages. Yes, I would be more than happy to. I just will not attempt to rebase this one myself, not comfortable doing so.