When creating a basket, the vendor has the ability to be altered from the original chosen vendor. Currently: 1. Choose Vendor 2. Create Basket 3. Assign a new vendor 4. This new vendor is not changed, it is still on the first vendor that was chosen. If the vendor can not be changed after initially choosing the vendor, the field should not be a dropdown, where it would appear that a change in vendor can be made. If the vendor can be changed during the creation of the basket, then this is not currently working.
Looks like a super old bug, good catch!
Created attachment 105572 [details] [review] Bug 25611: Use selected vendor when creating a basket We did not take into account the vendor selected. Test plan: 1. Choose Vendor 2. Create Basket 3. Assign a new vendor Without the patch this new vendor is not changed With the patch applied the vendor is changed 4. Edit the basket, change the vendor
Created attachment 105891 [details] [review] Bug 25611: Use selected vendor when creating a basket We did not take into account the vendor selected. Test plan: 1. Choose Vendor 2. Create Basket 3. Assign a new vendor Without the patch this new vendor is not changed With the patch applied the vendor is changed 4. Edit the basket, change the vendor Signed-off-by: Rhonda Kuiper <rkuiper@roundrocktexas.gov>
Created attachment 105929 [details] [review] Bug 25611: Use selected vendor when creating a basket We did not take into account the vendor selected. Test plan: 1. Choose Vendor 2. Create Basket 3. Assign a new vendor Without the patch this new vendor is not changed With the patch applied the vendor is changed 4. Edit the basket, change the vendor Signed-off-by: Rhonda Kuiper <rkuiper@roundrocktexas.gov> Signed-off-by: Rhonda Kuiper <rkuiper@roundrocktexas.gov>
Created attachment 106100 [details] [review] Bug 25611: Use selected vendor when creating a basket We did not take into account the vendor selected. Test plan: 1. Choose Vendor 2. Create Basket 3. Assign a new vendor Without the patch this new vendor is not changed With the patch applied the vendor is changed 4. Edit the basket, change the vendor Reported-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Rhonda Kuiper <rkuiper@roundrocktexas.gov> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
It's strange that we can change the vendor when the page title says "Create new basket for <Vendor>" (and the title is not updated when we select another vendor), but the patch does fix a bug. Passed QA
Pushed to master for 20.11, thanks to everybody involved!
backported to 20.05.x for 20.05.02
backported to 19.11.x for 19.11.08
Backported to 19.05.x branch for 19.05.14