On the datatables filtering on the ILL requests page, the "Clear filter" button at the top of the table is permanently disabled, even when the filter text box is populated. It should only be disabled when the text box is empty
Still valid. Owen, I've stared and glared... but can't figure it out. Would you mind having a look?
Created attachment 112565 [details] [review] Bug 25614: Move ILL request keyword filter to sidebar On the ILL request list page there are two filters for the table: One in the sidebar and one configured automatically by the DataTables plugin. I think these two systems are conflicting somehow to prevent the "clear filter" button in the table toolbar from working correctly. This patch doesn't fix the bug but avoids it: Since the filter field in the table toolbar is duplicating the functionality of the form in the sidebar, we could hide it and rely on the sidebar filter instead. To test, apply the patch and go to the ILL requests page in the staff interface. - The table of requests should display without a search form or "clear filter" button at the top. - The left-hand sidebar form should now have a "keyword" filter option which searches any column in the table. - Other filter fields should work as before.
Created attachment 115738 [details] [review] Bug 25614: Move ILL request keyword filter to sidebar On the ILL request list page there are two filters for the table: One in the sidebar and one configured automatically by the DataTables plugin. I think these two systems are conflicting somehow to prevent the "clear filter" button in the table toolbar from working correctly. This patch doesn't fix the bug but avoids it: Since the filter field in the table toolbar is duplicating the functionality of the form in the sidebar, we could hide it and rely on the sidebar filter instead. To test, apply the patch and go to the ILL requests page in the staff interface. - The table of requests should display without a search form or "clear filter" button at the top. - The left-hand sidebar form should now have a "keyword" filter option which searches any column in the table. - Other filter fields should work as before. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 115816 [details] [review] Bug 25614: Move ILL request keyword filter to sidebar On the ILL request list page there are two filters for the table: One in the sidebar and one configured automatically by the DataTables plugin. I think these two systems are conflicting somehow to prevent the "clear filter" button in the table toolbar from working correctly. This patch doesn't fix the bug but avoids it: Since the filter field in the table toolbar is duplicating the functionality of the form in the sidebar, we could hide it and rely on the sidebar filter instead. To test, apply the patch and go to the ILL requests page in the staff interface. - The table of requests should display without a search form or "clear filter" button at the top. - The left-hand sidebar form should now have a "keyword" filter option which searches any column in the table. - Other filter fields should work as before. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Thanks for fixing this Owen. Works as expected, no QA failures. Passing QA
Pushed to master for 21.05, thanks to everybody involved!
Pushed to 20.11.x for 20.11.03
Pushed to 20.05.x for 20.05.09
Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed.