To reproduce: 1. Open the patron categories list 2. Run: $ kshell k$ prove t/db_dependent/api/v1/oauth.t 3. Reload the patron categories list => FAIL: There's random data in there
Created attachment 105438 [details] [review] Bug 25623: Make sure oauth.t rolls back the db This patch adds a missing transaction wrapping one of the subtests. This is probably an oversight when refactoring this file. To test: 1. Open the patron categories page 2. Run: $ kshell k$ prove t/db_dependent/api/v1/oauth.t => SUCCESS: Tests pass 3. Reload the patron categories page => FAIL: There's random data in there 4. Apply this patch and repeat 2 5. Reload the patron categories page => SUCCESS: The random data from the previous tests is still there, but no new random data => SUCCESS: Tests still pass 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 105457 [details] [review] Bug 25623: Make sure oauth.t rolls back the db This patch adds a missing transaction wrapping one of the subtests. This is probably an oversight when refactoring this file. To test: 1. Open the patron categories page 2. Run: $ kshell k$ prove t/db_dependent/api/v1/oauth.t => SUCCESS: Tests pass 3. Reload the patron categories page => FAIL: There's random data in there 4. Apply this patch and repeat 2 5. Reload the patron categories page => SUCCESS: The random data from the previous tests is still there, but no new random data => SUCCESS: Tests still pass 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 105589 [details] [review] Bug 25623: Make sure oauth.t rolls back the db This patch adds a missing transaction wrapping one of the subtests. This is probably an oversight when refactoring this file. To test: 1. Open the patron categories page 2. Run: $ kshell k$ prove t/db_dependent/api/v1/oauth.t => SUCCESS: Tests pass 3. Reload the patron categories page => FAIL: There's random data in there 4. Apply this patch and repeat 2 5. Reload the patron categories page => SUCCESS: The random data from the previous tests is still there, but no new random data => SUCCESS: Tests still pass 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Pushed to master for 20.11, thanks to everybody involved!
backported to 20.05.x for 20.05.01
backported to 19.11.x for 19.11.07
Backported to 19.05.x branch for 19.05.13