The system preference PatronSelfRegistration description states: "library patrons to register or modify their account via the OPAC" however, in testing it, patron self modification is actually controlled by OPACPatronDetails system preference, which is in a different area of system preferences. At the very least, the description for PatronSelfRegistration should be updated to removed the reference to "modify". I would also propose that OPACPatronDetails and PatronSelfModificationBorrowerUnwantedField are placed together. It is very confusing to enable the modification function in one section, and define the display in another section.
Created attachment 105561 [details] [review] Bug 25675: Reword and reorganize sysprefs related to patron self modification To Test: 1: apply patch 2: restart all 3: go to System Preferences > OPAC 4: confirm "Self registration" section is now labeled "Self registration and modification" 5: confirm OPACPatronDetails is now in the "Self registration and modification" section 6: confirm PatronSelfRegistration now reads "(Allow / Don't allow) library patrons to register for an account via the OPAC." 7: set OPACPatronDetails to Don't allow 8: set PatronSelfRegistration to Allow 9: log into the opac and verify you're not able to edit your patron details on an existing account
Created attachment 105562 [details] [review] Bug 25675: Reword and reorganize sysprefs related to patron self modification To Test: 1: apply patch 2: restart all 3: go to System Preferences > OPAC 4: confirm "Self registration" section is now labeled "Self registration and modification" 5: confirm OPACPatronDetails is now in the "Self registration and modification" section 6: confirm PatronSelfRegistration now reads "(Allow / Don't allow) library patrons to register for an account via the OPAC." 7: set OPACPatronDetails to Don't allow 8: set PatronSelfRegistration to Allow 9: log into the opac and verify you're not able to edit your patron details on an existing account Signed-off-by: DonnaB <donna@bywatersolutions.com>
Created attachment 105616 [details] [review] Bug 25675: Reword and reorganize sysprefs related to patron self modification To Test: 1: apply patch 2: restart all 3: go to System Preferences > OPAC 4: confirm "Self registration" section is now labeled "Self registration and modification" 5: confirm OPACPatronDetails is now in the "Self registration and modification" section 6: confirm PatronSelfRegistration now reads "(Allow / Don't allow) library patrons to register for an account via the OPAC." 7: set OPACPatronDetails to Don't allow 8: set PatronSelfRegistration to Allow 9: log into the opac and verify you're not able to edit your patron details on an existing account Signed-off-by: DonnaB <donna@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 20.11, thanks to everybody involved!
backported to 20.05.x for 20.05.01
backported to 19.11.x for 19.11.07
Backported to 19.05.x branch for 19.05.13