While translating I noticed a couple of errors in intranet-tmpl/prog/en/includes/renew_strings.inc The message for auto_too_late is currently "Scheduled for automatic renewal and cannot yet be any more". I propose something like "Scheduled for automatic renewal and cannot be renewed any more". Also, the message for auto_too_much_oweing is "Scheduled for automatic renewal" (which is the same message as for auto_renew) I propose "Scheduled for automatic renewal and cannot be renewed because the patron has too many outstanding charges".
Created attachment 106356 [details] [review] Bug 25717: Improve automatic renewal error messages Improve wording and grammar for automatic renewal error messages. Test plan: 1. Review the error message changes and make sure they make sense.
Created attachment 106477 [details] [review] Bug 25717: Improve automatic renewal error messages Improve wording and grammar for automatic renewal error messages. Test plan: 1. Review the error message changes and make sure they make sense. The new message make sense to me. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Created attachment 106498 [details] [review] Bug 25717: Improve automatic renewal error messages Improve wording and grammar for automatic renewal error messages. Test plan: 1. Review the error message changes and make sure they make sense. The new message make sense to me. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Pushed to master for 20.11, thanks to everybody involved!
backported to 20.05.x for 20.05.03
patch does not apply cleanly on 19.11.x. please rebase if needed.