The status "ORDERED" is missing from the pull down list of status values when editing a suggestion, so the first option is selected "No status". This leads to data loss when editing a suggestion in the status "ORDERED". Worse: the status can't be reset to "ORDERED" and so no AVAILABLE notice can be sent to the patron.
Should we let the ability to modify the status if it's ordered?
Created attachment 105918 [details] [review] Bug 25751: Add ORDERED in dropdown list of suggestion's statuses
As they can do it now (even if unintentionally) I believe it would be safer to keep the beahviour for now.
(In reply to Katrin Fischer from comment #3) > As they can do it now (even if unintentionally) I believe it would be safer > to keep the beahviour for now. How can they do that?
I meant that you can edit a suggestion in ordered status and select one of the other status values - not sure if this is 'good' but it seems intended?
Maybe! Test plan: Create a suggestion, accept it, create a new order from this suggestion. Status is "ORDERED" Edit the suggestion => Without this patch the dropdown list does not have "Ordered", and if you save you lost the status => With this patch applied the dropdown list has "Ordered" preselected. You can save and preserve the status.
Created attachment 107893 [details] [review] Bug 25751: Add ORDERED in dropdown list of suggestion's statuses Signed-off-by: Holly Cooper <hc@interleaf.ie>
Created attachment 108311 [details] [review] Bug 25751: Add ORDERED in dropdown list of suggestion's statuses The status "ORDERED" is missing from the pull down list of status values when editing a suggestion, so the first option is selected "No status". This leads to data loss when editing a suggestion in the status "ORDERED". Worse: the status can't be reset to "ORDERED" and so no AVAILABLE notice can be sent to the patron. Test plan: - Create a suggestion, accept it, create a new order from this suggestion. - Verify status is "ORDERED" - Edit the suggestion => Without this patch the dropdown list does not have "Ordered", and if you save you lost the status => With this patch applied the dropdown list has "Ordered" preselected. You can save and preserve the status. Signed-off-by: Holly Cooper <hc@interleaf.ie> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 20.11, thanks to everybody involved!
backported to 20.05.x for 20.05.04
backported to 19.11.x for 19.11.10
Not backported to oldoldstable (19.05.x). Feel free to ask if it's needed.